From: Timur Tabi <timur@tabi.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: "Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>,
Mark Brown <broonie@kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"guangyu.chen@freescale.com" <guangyu.chen@freescale.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 01/15] ASoC: fsl-ssi: Use regmap
Date: Thu, 27 Feb 2014 10:06:33 -0600 [thread overview]
Message-ID: <530F6289.7030805@tabi.org> (raw)
In-Reply-To: <20140227152332.GA30791@pengutronix.de>
On 02/27/2014 09:23 AM, Markus Pargmann wrote:
>>> > >+static const struct regmap_config fsl_ssi_regconfig = {
>>> > >+ .max_register = CCSR_SSI_SACCDIS,
>>> > >+ .reg_bits = 32,
>>> > >+ .val_bits = 32,
>>> > >+ .reg_stride = 4,
>>> > >+#ifdef PPC
>>> > >+ .val_format_endian = REGMAP_ENDIAN_BIG,
>>> > >+#endif
>> >
>> >Is this really needed for your PPC platforms?
> I don't know if this is necessary. I don't have any PPC hardware where I
> could test this driver. This is just a guess how regmap for this driver
> and PPC should look like based on the previous code. So it would be
> great if anyone could test this regmap config on PPC.
I will *try* to test this out.
next prev parent reply other threads:[~2014-02-27 16:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 16:02 [PATCH 00/15] ASoC: fsl-ssi: Driver cleanup Markus Pargmann
2014-02-26 16:02 ` [PATCH 01/15] ASoC: fsl-ssi: Use regmap Markus Pargmann
2014-02-27 2:08 ` Li.Xiubo
2014-02-27 15:23 ` Markus Pargmann
2014-02-27 16:06 ` Timur Tabi [this message]
2014-03-05 6:21 ` Mark Brown
2014-03-05 7:04 ` Li.Xiubo
2014-03-05 7:07 ` Li.Xiubo
2014-02-26 16:02 ` [PATCH 02/15] ASoC: fsl-ssi: Remove fsl_ssi_setup Markus Pargmann
2014-02-26 16:02 ` [PATCH 03/15] ASoC: fsl-ssi: Move debugging to seperate file Markus Pargmann
2014-02-26 16:02 ` [PATCH 04/15] ASoC: fsl-ssi: Use dev_name for DAI driver struct Markus Pargmann
2014-02-26 16:02 ` [PATCH 05/15] ASoC: fsl-ssi: Move imx-specific probe to seperate function Markus Pargmann
2014-02-26 16:02 ` [PATCH 06/15] ASoC: fsl-ssi: Remove useless DMA code Markus Pargmann
2014-02-26 16:02 ` [PATCH 07/15] ASoC: fsl-ssi: baud clock error handling Markus Pargmann
2014-02-26 16:02 ` [PATCH 08/15] ASoC: fsl-ssi: Cleanup probe function Markus Pargmann
2014-02-26 16:02 ` [PATCH 09/15] ASoC: fsl-ssi: Remove unnecessary variables from ssi_private Markus Pargmann
2014-02-26 16:02 ` [PATCH 10/15] ASoC: fsl-ssi: reorder and document fsl_ssi_private Markus Pargmann
2014-02-26 16:02 ` [PATCH 11/15] ASoC: fsl-ssi: Fix register values when disabling Markus Pargmann
2014-02-26 16:02 ` [PATCH 12/15] ASoC: fsl-ssi: Only enable baudclk when used Markus Pargmann
2014-02-26 16:02 ` [PATCH 13/15] ASoC: fsl-ssi: Set default dai-fmts Markus Pargmann
2014-02-26 16:02 ` [PATCH 14/15] ASoC: fsl-ssi: Transmit enable synchronization Markus Pargmann
2014-02-26 16:02 ` [PATCH 15/15] ASoC: fsl-ssi: Update binding documentation Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F6289.7030805@tabi.org \
--to=timur@tabi.org \
--cc=Fabio.Estevam@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guangyu.chen@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mpa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).