From: Jyri Sarha <jsarha@ti.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org,
Rajeev Kumar <rajeev-dlh.kumar@st.com>,
patches@opensource.wolfsonmicro.com,
Vishwas A Deshpande <vishwas.a.deshpande@ti.com>,
M R Swami Reddy <mr.swami.reddy@ti.com>,
Bard Liao <bardliao@realtek.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: codecs: Replace instances of rtd->codec with dai->codec
Date: Fri, 14 Mar 2014 12:15:20 +0200 [thread overview]
Message-ID: <5322D6B8.2080604@ti.com> (raw)
In-Reply-To: <1394742294-14698-1-git-send-email-lars@metafoo.de>
On 03/13/2014 10:24 PM, Lars-Peter Clausen wrote:
> With CODEC to CODEC links rtd->codec does not necessarily point to the driver's
> CODEC. CODEC drivers should always use dai->codec and never even look at the PCM
> runtime.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
[...]
> diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c
> index d3517a9..cc1c9c2 100644
> --- a/sound/soc/codecs/tlv320aic31xx.c
> +++ b/sound/soc/codecs/tlv320aic31xx.c
> @@ -753,10 +753,9 @@ static int aic31xx_setup_pll(struct snd_soc_codec *codec,
>
> static int aic31xx_hw_params(struct snd_pcm_substream *substream,
> struct snd_pcm_hw_params *params,
> - struct snd_soc_dai *tmp)
> + struct snd_soc_dai *dai)
> {
> - struct snd_soc_pcm_runtime *rtd = substream->private_data;
> - struct snd_soc_codec *codec = rtd->codec;
> + struct snd_soc_codec *codec = dai->codec;
> u8 data = 0;
>
> dev_dbg(codec->dev, "## %s: format %d width %d rate %d\n",
[...]
Concerning the part above.
Acked-by: Jyri Sarha <jsarha@ti.com>
Best regards,
Jyri
next prev parent reply other threads:[~2014-03-14 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 20:24 [PATCH] ASoC: codecs: Replace instances of rtd->codec with dai->codec Lars-Peter Clausen
2014-03-14 9:11 ` Charles Keepax
2014-03-14 10:15 ` Jyri Sarha [this message]
2014-03-18 12:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322D6B8.2080604@ti.com \
--to=jsarha@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=mr.swami.reddy@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=vishwas.a.deshpande@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).