From: Jyri Sarha <jsarha@ti.com>
To: Jean-Francois Moine <moinejf@free.fr>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Xiubo Li <Li.Xiubo@freescale.com>,
linux-kernel@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [alsa-devel] [PATCH v2 3/4] ASoC: simple-card: accept many DAI links
Date: Fri, 14 Mar 2014 13:16:12 +0200 [thread overview]
Message-ID: <5322E4FC.7060605@ti.com> (raw)
In-Reply-To: <d71a2b62b331302772d35b3cd35c6dc5da1e9e5d.1394533640.git.moinejf@free.fr>
On 03/11/2014 11:36 AM, Jean-Francois Moine wrote:
> Some simple audio cards may have many DAI links.
> This patch extends the simple-card driver for handling such cards.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
[...]
Why can't you just use two simple-card instances in your setup?
You need to update the DT-binding document too when you are changing the
binding. That way it would also be easier to follow what you are trying
to accomplish here.
The sysclk and tdm properties appear to only work in the dais of the
first dai-link and __asoc_simple_card_dai_init() will not be called for
other dais at all. The DT-binding of this implementation would look
pretty hairy to me.
Best regards,
Jyri
next prev parent reply other threads:[~2014-03-14 11:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 10:27 [PATCH v2 0/4] ASoC: simple-card: DT fix and multi DAI links extension Jean-Francois Moine
2014-03-11 9:03 ` [PATCH v2 1/4] ASoC: simple-card: Fix the reference count of device nodes Jean-Francois Moine
2014-03-14 19:57 ` Mark Brown
2014-03-11 9:21 ` [PATCH v2 2/4] ASoC: simple-card: dynamically allocate the DAI link array Jean-Francois Moine
2014-03-11 9:36 ` [PATCH v2 3/4] ASoC: simple-card: accept many DAI links Jean-Francois Moine
2014-03-12 5:20 ` Li.Xiubo
2014-03-14 18:58 ` [alsa-devel] " Jean-Francois Moine
2014-03-14 11:16 ` Jyri Sarha [this message]
2014-03-14 18:40 ` Jean-Francois Moine
2014-03-15 9:14 ` Jyri Sarha
2014-03-17 16:19 ` Mark Brown
2014-03-11 9:58 ` [PATCH v2 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322E4FC.7060605@ti.com \
--to=jsarha@ti.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).