From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
spapothi@codeaurora.org, plai@codeaurora.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v1 6/6] ASoC: codecs: lpass-va-macro: add dapm widgets and routes
Date: Mon, 26 Oct 2020 15:01:52 -0500 [thread overview]
Message-ID: <55ba8a1a-df67-8451-dedd-49e6c0cf82a6@linux.intel.com> (raw)
In-Reply-To: <20201026141945.19707-7-srinivas.kandagatla@linaro.org>
> +static int va_dmic_clk_enable(struct snd_soc_component *component,
> + u32 dmic, bool enable)
> +{
> + struct va_macro *va = snd_soc_component_get_drvdata(component);
> + u8 dmic_clk_en = 0x01;
> + u16 dmic_clk_reg = 0;
> + s32 *dmic_clk_cnt = NULL;
> + u8 *dmic_clk_div = NULL;
> + u8 freq_change_mask = 0;
the 4 initializations above are ignored, remove?
prev parent reply other threads:[~2020-10-26 23:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 14:19 [PATCH v1 0/6] ASoC: codecs: add support for LPASS Codec macros Srinivas Kandagatla
2020-10-26 14:19 ` [PATCH v1 1/6] ASoC: qcom: dt-bindings: add bindings for lpass wsa macro codec Srinivas Kandagatla
2020-10-26 14:19 ` [PATCH v1 2/6] ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro Srinivas Kandagatla
2020-10-26 19:45 ` Pierre-Louis Bossart
2020-10-26 14:19 ` [PATCH v1 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route Srinivas Kandagatla
2020-10-26 19:58 ` Pierre-Louis Bossart
2020-10-27 10:15 ` Srinivas Kandagatla
2020-10-27 16:14 ` Pierre-Louis Bossart
2020-10-26 14:19 ` [PATCH v1 4/6] ASoC: qcom: dt-bindings: add bindings for lpass va macro codec Srinivas Kandagatla
2020-10-26 14:19 ` [PATCH v1 5/6] ASoC: codecs: lpass-va-macro: Add support to VA Macro Srinivas Kandagatla
2020-10-26 14:19 ` [PATCH v1 6/6] ASoC: codecs: lpass-va-macro: add dapm widgets and routes Srinivas Kandagatla
2020-10-26 20:01 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ba8a1a-df67-8451-dedd-49e6c0cf82a6@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).