From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jerome Brunet <jbrunet@baylibre.com>, alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org
Subject: Re: [PATCH] ASoC: core: use less strict tests for dailink capabilities
Date: Fri, 24 Jul 2020 14:05:55 -0500 [thread overview]
Message-ID: <576823fb-a8a8-1f74-b7e2-d33b734022a7@linux.intel.com> (raw)
In-Reply-To: <1jlfj98gb4.fsf@starbuckisacylon.baylibre.com>
> Again, this is changing the original meaning of the flag from "playback
> allowed" to "playback required".
>
> This patch (or the orignal) does not explain why this change of meaning
> is necessary ? The point I was making here [0] still stands.
>
> If your evil plan is to get rid of 2 of the 4 flags, why go through the
> trouble of the changing the meaning and effect of one them ?
My intent was to have a non-ambiguous definition.
I don't know 'playback allowed' means. What is the point of using this
flag if it may or may not accurately describe what is actually
implemented? And how can we converge the use of flags since in the
contrary 'playback_only' is actually a clear indication of what the link
does. We've got to align on the semantics, and I really don't see the
point of watering-down definitions. When things are optional or poorly
defined, the confusion continues.
WFIW, my 'evil' plan was to rename 'dpcm_playback' as 'can_playback'
(same for capture) and replace 'playback_only' by 'can_playback = 1;
can_capture = 0'. So this first step was really to align them on the
expected behavior and minimal requirements.
next prev parent reply other threads:[~2020-07-24 19:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 18:05 [PATCH] ASoC: core: use less strict tests for dailink capabilities Pierre-Louis Bossart
2020-07-24 8:31 ` Jerome Brunet
2020-07-24 19:05 ` Pierre-Louis Bossart [this message]
2020-07-27 9:42 ` Jerome Brunet
2020-07-27 14:13 ` Pierre-Louis Bossart
2020-07-27 15:15 ` Jerome Brunet
2020-07-27 15:26 ` Pierre-Louis Bossart
2020-07-29 15:46 ` [PATCH] ASoC: core: restore dpcm flags semantics Jerome Brunet
2020-07-29 15:56 ` Pierre-Louis Bossart
2020-07-30 9:04 ` Jerome Brunet
2020-07-30 16:06 ` Pierre-Louis Bossart
2020-07-30 18:52 ` Mark Brown
2020-07-31 12:16 ` Jerome Brunet
2020-07-31 17:42 ` Mark Brown
2020-07-31 8:06 ` Jerome Brunet
2020-07-30 18:12 ` Mark Brown
2020-07-31 18:54 ` [PATCH] ASoC: core: use less strict tests for dailink capabilities Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576823fb-a8a8-1f74-b7e2-d33b734022a7@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).