From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B281C4363A for ; Fri, 23 Oct 2020 14:35:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 881122168B for ; Fri, 23 Oct 2020 14:35:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="N/5OaHV3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 881122168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B69C5182D; Fri, 23 Oct 2020 16:34:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B69C5182D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603463742; bh=7JndE12dqndPYsuGgE6G/sbFBsuPkzGUlz+PLYDLJMc=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=N/5OaHV3KWgowYaQCBaibFz6/i8TYd0yyO540PX8LrBq6hsIxXSvzEuj1pFmFC8C3 OoAum0GA0+iHAGO7ySfJsBV9dPmWdsEJk4fVvBTiyxvS6F9wtQCieO4lVuuVzrt9Ax PQfs+P6TJByzeH5eH/hPrGaBDQ0OXH4aeswryWKw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 49DB5F80253; Fri, 23 Oct 2020 16:34:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C6A5DF8025A; Fri, 23 Oct 2020 16:34:50 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5CD2BF80247; Fri, 23 Oct 2020 16:34:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5CD2BF80247 IronPort-SDR: 4SDkMJw+YLnW7YtkcWn2PAOSyw8H7fK5RKvKuL+NGlDuRsdxiaAfEGFoe1m6kt8gFHtY8LqGrf O2tgNSLCkk+w== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="166898713" X-IronPort-AV: E=Sophos;i="5.77,408,1596524400"; d="scan'208";a="166898713" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 07:34:33 -0700 IronPort-SDR: 7NRNd9XWr8JQaYlc8uXJVIPHN/hjDky97EM1W37q9ubM4h0tX+Vrv8Hu743rgxIVTgE+d/K3xk WZZJ2TOt26Xg== X-IronPort-AV: E=Sophos;i="5.77,408,1596524400"; d="scan'208";a="317108006" Received: from srussjr-mobl.amr.corp.intel.com (HELO [10.212.52.219]) ([10.212.52.219]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 07:34:31 -0700 Subject: Re: [PATCH] ASoC: Intel: Enable coredump in kconfig To: Gustaw Lewandowski , alsa-devel@alsa-project.org References: <20201023105727.21008-1-gustaw.lewandowski@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <5b10b9da-2a8f-bd13-795d-f7efb47a06fa@linux.intel.com> Date: Fri, 23 Oct 2020 09:33:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201023105727.21008-1-gustaw.lewandowski@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: cezary.rojewski@intel.com, patch@alsa-project.org, tiwai@suse.de, lgirdwood@gmail.com, Piotr Maziarz , broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/23/20 5:57 AM, Gustaw Lewandowski wrote: > From: Piotr Maziarz > > WANT_DEV_COREDUMP flag is needed here if this driver is only one > using dev_coredump feature. > > Signed-off-by: Piotr Maziarz > Signed-off-by: Gustaw Lewandowski > --- > sound/soc/intel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > index a5b446d5af19..c215156e2e18 100644 > --- a/sound/soc/intel/Kconfig > +++ b/sound/soc/intel/Kconfig > @@ -4,6 +4,7 @@ config SND_SOC_INTEL_SST_TOPLEVEL > default y > depends on X86 || COMPILE_TEST > select SND_SOC_INTEL_MACH > + select WANT_DEV_COREDUMP > help > Intel ASoC SST Platform Drivers. If you have a Intel machine that > has an audio controller with a DSP and I2S or DMIC port, then to the best of my knowledge the only user of device coredump is: intel/catpt/dsp.c: dev_coredumpv(cdev->dev, dump, dump_size, GFP_KERNEL); so shouldn't this change be added to catpt only?