From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF35BC433DB for ; Wed, 24 Mar 2021 12:06:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0063B61A02 for ; Wed, 24 Mar 2021 12:06:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0063B61A02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=d-systems.ee Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9EF2D1614; Wed, 24 Mar 2021 13:05:37 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9EF2D1614 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1616587587; bh=MBLKFHhI3N2jnjA1cHwdFTvKmK4U4Lm1Cjsup9MP2eQ=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qjW5i7f+dVz4X8LtEZyCuIkLICzNLknFgXGKwg42lHktoz6v3Br0kjjngJiP4Nclm 5ibvCmsXp2G+dfXnDAxS40F6GluyL+UvMfyRZFf+29icEGTf7Me3Cwp0gasff0gHIl UcKCtmFSVmf7e6HMMBwzGKFV/Kim4BQNgZ71MnmE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1764CF800FF; Wed, 24 Mar 2021 13:05:37 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5F416F8016B; Wed, 24 Mar 2021 13:05:36 +0100 (CET) Received: from mail.d-sys.org (70-31-180-213.sta.estpak.ee [213.180.31.70]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0AE5EF800FF for ; Wed, 24 Mar 2021 13:05:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0AE5EF800FF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=d-systems.ee header.i=@d-systems.ee header.b="enLYlb3Y"; dkim=pass (2048-bit key) header.d=d-systems.ee header.i=@d-systems.ee header.b="VldZ4HTe" Received: from mail.d-sys.org (localhost [127.0.0.1]) by mail.d-sys.org (Postfix) with ESMTP id 9760A60C47; Wed, 24 Mar 2021 14:05:26 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=d-systems.ee; s=mail; t=1616587527; bh=SkwzTh8yrdqriQuUanVneW3UEuJfiLkP5cRnSLuIrkY=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=enLYlb3YchJTMhx13cWndDg1KISIZxskUui+F1ETNae+NMCFB+CUjoh1vMlIP9p5y 9SoW1JtzcPqDmzJaIsYgJHLSFP6NFLWYJbgDDUfNAFbsDWQ98qS73LeiyIkw2lITAM 1GoBHbs7HAtpGPKDBbfOEbBmJ17+krOy75f9+o0U/jbI4/imJ7yBW3wkhTxeK2/1fO UbsnbOgOb5LaRPM8DlGKbjV4iwAaVivuMaP+Ihey09N6Uh1QEHQDe2jsr+7RLgrncj A5VBK8IL0cf0jiwUYG7FWVcO1hCavN+QL5+k2w397CylnzJ7Su5Vxb2XQpcXrKUn/s z1pKiLwz4PuDw== Received: from [10.255.10.80] (GW.ds.local [10.255.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: dmitry@d-systems.ee) by mail.d-sys.org (Postfix) with ESMTPSA id 329C960A59; Wed, 24 Mar 2021 14:05:26 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=d-systems.ee; s=mail; t=1616587526; bh=SkwzTh8yrdqriQuUanVneW3UEuJfiLkP5cRnSLuIrkY=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=VldZ4HTePNjn5VADZbROy5B2J1mUa02bcWrXMMlt5jXq6OPDTh9D4MVMSIIy/gNyz zUFReV0f7pFBg2zkKxKmP68yfR/f9Epo5XC1kFBq50oVdYZPDCPrkaam8zgQWyoqCm yyUpTf0XmbDD/8txRi1cugWfPdZYd4IQ686jGPWh9MT3lieoZaGhx4lzX7mf+aCk0m SserP9cg5SAD1SBHIQmBksRi+mbX1ODc5+pJIghp8KvkuMPzRb+LkzI3UCTieLji4K dBJEfi3/38+MptoEh+PnioeOUy3cNFYnmz75nIlnWm/s4KVtQceLwdfbFG8i7U193N Lty+M47BEGduw== Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect To: Ikjoon Jang , Joakim Tjernlund References: <20210324105153.2322881-1-ikjn@chromium.org> From: Dmitry Panchenko | d-Systems Message-ID: <62a2ff2e-183f-1aeb-a4a0-d0d57b976179@d-systems.ee> Date: Wed, 24 Mar 2021 14:05:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-AV-Checked: ClamAV using ClamSMTP Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: linux-kernel@vger.kernel, alsa-devel@alsa-project.org, Dylan Robinson , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Takashi Iwai , Alexander Tsoy , Kai-Heng Feng , Gregor Pintar , Olivia Mackintosh , open list X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Dear list administrator, please remove dmitry@d-systems.ee from this list. Kind regards, Dmitry Panchenko d-Systems OÜ Ⓐ Lai 6, Tartu 51005, Estonia Ⓦ www.d-systems.ee On 24.03.21 14:03, Ikjoon Jang wrote: > > > On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund > > > wrote: > > On Wed, 2021-03-24 at 18:51 +0800, Ikjoon Jang wrote: > > Logitech ConferenceCam Connect is a compound USB device with UVC and > > UAC. Not 100% reproducible but sometimes it keeps responding > STALL to > > every control transfer once it receives get_freq request. > > > > This patch adds 046d:0x084c to a snd_usb_get_sample_rate_quirk list. > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203419 > > Signed-off-by: Ikjoon Jang > > > Most Logitech USB headset I got needs a delay in > snd_usb_ctl_msg_quirk() > Have you tried to add say 20 ms delay in there? > > > I didn't try that. But it sounds reasonable to me. > > let me try that quirk here. If that is the case, HID might need that > delay also. Logitech Group webcam had a similar problem on control > xfer of get_report from an another interface for HID. > > And 20ms can be too long if it's applied to every control transfer. I > will test the device with shorter delay if you didn't try it before. > > Any additional advice is welcome. > > Thanks! > >  Jocke >