alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: SOF: Turn "firmware boot complete" message into a dbg message
Date: Thu, 2 Apr 2020 14:18:08 -0500	[thread overview]
Message-ID: <67dc07e1-aeb2-66e3-5bea-467b5ecb6974@linux.intel.com> (raw)
In-Reply-To: <20200402184948.3014-2-hdegoede@redhat.com>



On 4/2/20 1:49 PM, Hans de Goede wrote:
> Using a Canon Lake machine with the SOF driver causes dmesg to fill
> up with a ton of these messages:
> 
> [  275.902194] sof-audio-pci 0000:00:1f.3: firmware boot complete
> [  351.529358] sof-audio-pci 0000:00:1f.3: firmware boot complete
> [  560.049047] sof-audio-pci 0000:00:1f.3: firmware boot complete
> etc.
> 
> Since the DSP is powered down when not in used this happens everytime
> e.g. a notification plays, polluting dmesg.
> 
> Turn this messages into a debug message, matching what the code already
> does for the ""booting DSP firmware" message.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Thanks Hans.

> ---
>   sound/soc/sof/loader.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/loader.c b/sound/soc/sof/loader.c
> index fc4ab51bacf4..4760a9734585 100644
> --- a/sound/soc/sof/loader.c
> +++ b/sound/soc/sof/loader.c
> @@ -603,7 +603,7 @@ int snd_sof_run_firmware(struct snd_sof_dev *sdev)
>   	}
>   
>   	if (sdev->fw_state == SOF_FW_BOOT_COMPLETE)
> -		dev_info(sdev->dev, "firmware boot complete\n");
> +		dev_dbg(sdev->dev, "firmware boot complete\n");
>   	else
>   		return -EIO; /* FW boots but fw_ready op failed */
>   
> 

  reply	other threads:[~2020-04-02 19:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 18:49 [PATCH 1/2] ASoC: SOF: Fix "no reply expected" error during firmware-boot Hans de Goede
2020-04-02 18:49 ` [PATCH 2/2] ASoC: SOF: Turn "firmware boot complete" message into a dbg message Hans de Goede
2020-04-02 19:18   ` Pierre-Louis Bossart [this message]
2020-04-03 13:40   ` Applied "ASoC: SOF: Turn "firmware boot complete" message into a dbg message" to the asoc tree Mark Brown
2020-04-02 19:15 ` [PATCH 1/2] ASoC: SOF: Fix "no reply expected" error during firmware-boot Pierre-Louis Bossart
2020-04-03  8:01   ` Hans de Goede
2020-04-03 13:17     ` Pierre-Louis Bossart
2020-04-20 12:48       ` Mark Brown
2020-04-20 15:17         ` Pierre-Louis Bossart
2020-04-20 20:28           ` Kai Vehmanen
2020-04-21 13:22             ` Hans de Goede
2020-04-21 13:36               ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67dc07e1-aeb2-66e3-5bea-467b5ecb6974@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).