From: "Martin Povišer" <povik@cutebit.org>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
"Sven Peter" <sven@svenpeter.dev>,
linux-kernel@vger.kernel.org, "Hector Martin" <marcan@marcan.st>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Kettenis" <kettenis@openbsd.org>,
"Martin Povišer" <povik+lin@cutebit.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>
Subject: Re: [RFC PATCH 0/5] Apple Macs machine-level ASoC driver
Date: Fri, 22 Apr 2022 14:36:03 +0200 [thread overview]
Message-ID: <6F6130F3-381C-4AB7-B618-CDC4C4A37C9B@cutebit.org> (raw)
In-Reply-To: <YmKeEKa0w2xLM9cL@sirena.org.uk>
> On 22. 4. 2022, at 14:22, Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Apr 22, 2022 at 01:44:06PM +0200, Martin Povišer wrote:
>
>>> So previously each speaker would get two slots but now it just gets one?
>
>> No the other way around. Previously (with the driver as it is RFCed),
>> each speaker gets a single slot, and 'Left', 'Right' and ‘LeftRight'
>> values of the routing control don't do anything different from each
>> other (well except maybe 'LeftRight' lessens the volume due to how
>> the chip handles the edge case of mixing down two channels from the
>> same slot).
>
>> With the new arrangement I am proposing, the two speakers in a left-right
>> pair get both the same two slots, meaning they get to choose one of the
>> two slots based on the 'Left' 'Right' value of their routing control.
>
> Ah, I think the confusion here is that I'm using slot and channel
> interchangably whereas you're saying that previously the driver would
> allocate two channels to each speaker with duplicate data?
I guess you could say that. Not that there’s duplicate data on the I2S
bus, but the speaker amp would previously be configured to look for the
left and right channel in the same TDM slot (see e.g. set_tdm_slot of
tas2770 [0]). (Each speaker amp drives a single speaker, but it still
has a notion of left and right channel.)
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/soc/codecs/tas2770.c#n416
next prev parent reply other threads:[~2022-04-22 13:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 0:04 [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 1/5] dt-bindings: sound: Add Apple Macs sound system Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 2/5] HACK: ASoC: Add card->filter_controls hook Martin Povišer
2022-03-31 11:34 ` Mark Brown
2022-03-31 0:04 ` [RFC PATCH 3/5] HACK: ASoC: Tolerate N-cpus-to-M-codecs links Martin Povišer
2022-04-04 12:28 ` Mark Brown
2022-04-22 14:06 ` Martin Povišer
2022-04-25 12:25 ` Mark Brown
2022-04-25 12:34 ` Martin Povišer
2022-04-25 12:55 ` Mark Brown
2022-04-25 13:11 ` Martin Povišer
2022-04-25 13:46 ` Mark Brown
2022-04-25 13:55 ` Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 4/5] ASoC: Introduce snd_soc_of_get_dai_link_cpus Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 5/5] ASoC: Add macaudio machine driver Martin Povišer
2022-03-31 11:59 ` Mark Brown
[not found] ` <4651D426-BA1A-418F-90E5-278C705DA984@cutebit.org>
2022-03-31 12:56 ` Mark Brown
2022-03-31 12:34 ` [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Mark Brown
2022-03-31 13:28 ` Hector Martin
2022-03-31 14:33 ` Mark Brown
[not found] ` <CCE4A06E-6D6F-457D-B3C5-C36209BF38D3@cutebit.org>
2022-03-31 14:18 ` Mark Brown
[not found] ` <6D199EAB-FE14-4030-96A7-2E0E89D25FAB@cutebit.org>
2022-03-31 15:36 ` Mark Brown
2022-04-22 10:43 ` Martin Povišer
2022-04-22 11:19 ` Mark Brown
2022-04-22 11:28 ` Martin Povišer
2022-04-22 11:33 ` Mark Brown
2022-04-22 11:44 ` Martin Povišer
2022-04-22 12:22 ` Mark Brown
2022-04-22 12:36 ` Martin Povišer [this message]
2022-04-22 12:44 ` Mark Brown
2022-04-22 12:53 ` Martin Povišer
2022-04-22 13:06 ` Mark Brown
2022-04-22 13:59 ` Martin Povišer
2022-04-05 9:31 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6F6130F3-381C-4AB7-B618-CDC4C4A37C9B@cutebit.org \
--to=povik@cutebit.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).