From: "Sridharan, Ranjani" <ranjani.sridharan@intel.com>
To: "Rojewski, Cezary" <cezary.rojewski@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "tiwai@suse.com" <tiwai@suse.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: pcm: DRAIN support reactivation
Date: Tue, 3 Nov 2020 17:11:47 +0000 [thread overview]
Message-ID: <6a701e24725c938d7ffa7f119159062a395d4bf6.camel@intel.com> (raw)
In-Reply-To: <20201026100129.8216-1-cezary.rojewski@intel.com>
On Mon, 2020-10-26 at 11:01 +0100, Cezary Rojewski wrote:
> soc-pcm's dpcm_fe_dai_do_trigger() supported DRAIN commnad up to
> kernel
> v5.4 where explicit switch(cmd) has been introduced which takes into
> account all SNDRV_PCM_TRIGGER_xxx but SNDRV_PCM_TRIGGER_DRAIN. Update
> switch statement to reactive support for it.
>
> As DRAIN is somewhat unique by lacking negative/stop counterpart,
> bring
> behaviour of dpcm_fe_dai_do_trigger() for said command back to its
> pre-v5.4 state by adding it to START/RESUME/PAUSE_RELEASE group.
>
> Fixes: acbf27746ecf ("ASoC: pcm: update FE/BE trigger order based on
> the command")
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Looks good to me. Thanks, Cezary!
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
next prev parent reply other threads:[~2020-11-03 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 10:01 [PATCH] ASoC: pcm: DRAIN support reactivation Cezary Rojewski
2020-11-03 17:11 ` Sridharan, Ranjani [this message]
2020-11-05 16:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a701e24725c938d7ffa7f119159062a395d4bf6.camel@intel.com \
--to=ranjani.sridharan@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).