From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4510C352BE for ; Sat, 18 Apr 2020 18:49:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39A6721D93 for ; Sat, 18 Apr 2020 18:49:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="XkvqW648" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39A6721D93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 97C24167D; Sat, 18 Apr 2020 20:48:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 97C24167D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587235753; bh=5ymsXNiuHyrMfrARiiIgk9s3jHf+ieH2hrciNDNB9Ts=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XkvqW648aRHSYFvkmJWyXzH0WByeYRNFuxNLnQms9LqKRet2c195uPJTMlmH8McuX UfBrGvxj2r0EPn7yhAKwh3H6yPYqbXvWZYP4HLsMCJU90OcrUp17TUgXlEYTSGZMBI 74GIRBwJcbNZm3h5YapIGLp/VoI5PLpHMxQSp/HA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F2778F8028A; Sat, 18 Apr 2020 20:47:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6F718F8028C; Sat, 18 Apr 2020 20:47:11 +0200 (CEST) Received: from smtprelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C6D70F8028A for ; Sat, 18 Apr 2020 20:47:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C6D70F8028A Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 3F8761802EC1C; Sat, 18 Apr 2020 18:47:01 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: loss63_59e6ce4dc9051 X-Filterd-Recvd-Size: 2163 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Sat, 18 Apr 2020 18:46:57 +0000 (UTC) Message-ID: <6bb8d99e6e56fa1622fc7238c1ae37c3b3510ded.camel@perches.com> Subject: Re: [RFC PATCH 1/9] kernel.h: add do_empty() macro From: Joe Perches To: Randy Dunlap , linux-kernel@vger.kernel.org Date: Sat, 18 Apr 2020 11:44:43 -0700 In-Reply-To: <20200418184111.13401-2-rdunlap@infradead.org> References: <20200418184111.13401-1-rdunlap@infradead.org> <20200418184111.13401-2-rdunlap@infradead.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Dmitry Torokhov , Zzy Wysm , "J. Bruce Fields" , target-devel@vger.kernel.org, Dave Jiang , linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, Vishal Verma , linux-input@vger.kernel.org, Alexander Viro , Dan Williams , Andrew Morton , linux-nfs@vger.kernel.org, "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Takashi Iwai , Chuck Lever , linux-fsdevel@vger.kernel.org, Johannes Berg , Linus Torvalds X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 2020-04-18 at 11:41 -0700, Randy Dunlap wrote: > Add the do_empty() macro to silence gcc warnings about an empty body > following an "if" statement when -Wextra is used. > > However, for debug printk calls that are being disabled, use either > no_printk() or pr_debug() [and optionally dynamic printk debugging] > instead. [] > +#define do_empty() do { } while (0) If this is really useful (I think the warning is somewhat silly) bikeshed: I think do_nothing() is more descriptive