From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>, ojab // <ojab@ojab.ru>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Subject: Re: [alsa-devel] No sound since 5.4 on skl_n88l25_s4567
Date: Wed, 15 Jan 2020 19:04:48 -0600 [thread overview]
Message-ID: <6d0f1830-a2f0-997a-99cc-05c268acefc6@linux.intel.com> (raw)
In-Reply-To: <87r2001bsi.wl-kuninori.morimoto.gx@renesas.com>
>> a) remove the error handling after soc_dapm_add_routes() to be
>> backwards compatible with Intel problematic machine drivers. Not
>> really nice for everyone else.
>>
>> b) remove this error conditionally so that legacy Intel solutions
>> still work but new ones deal with errors upfront.
>>
>> I am not sure if there's a 'clean' way to implement b), maybe with a
>> Kconfig selected by some machine drivers? Morimito-san, any
>> suggestions now that we've root caused the problem (copied again below
>> for reference)?
>
> Is it possible to *real* fixup in the future, some day ?
Quite unlikely I am afraid. This is a mismatch between topology and
machine driver, and there are no planned updates of those topologies
(which were never released for upstream use).
In this case I guess the topology file was taken from a ChromeOS
distribution (based on v4.4 IIRC), so there's really no guarantee that a
fix would ever reach the user without a convoluted set of manual updates.
> We need correct code, but backward compatibility is also needed.
> Not only Intel but some machine might have similar issue,
> so, how about to indicate WARNING, and comment ?
>
> Like this
>
> ret = snd_soc_dapm_add_routes(dapm,
> component->driver->dapm_routes,
> component->driver->num_dapm_routes);
> if (ret < 0)
> - goto err_probe;
> + /*
> + * This is error, but legacy Intel want
> + * compatibility until xxxx.
> + * call "goto err_probe" after that
> + */
> + dev_warn(dev, "DAPM route add failed.")
we already had a warning before:
[ 22.364318] skl_n88l25_s4567 skl_n88l25_s4567: ASoC: Failed to add
route iDisp3_out -> direct -> iDisp3 Tx
and it was ignored since there was no functional impact....
Maybe we could have some sort of boolean flag in the component->driver
definition and explicitly request a backwards-compatible behavior (e.g.
for all SKL/KBL machine drivers) when that driver is known to be flaky.
There's already things like 'fully_routed', maybe we can add something
such as 'disable_route_check'?
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-16 1:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKzrAgTD2oeyajKGOaPea98vZ-uKJOn6uOqABA+CKtpvYpWYvQ@mail.gmail.com>
[not found] ` <CAKzrAgTCE4btXr04pkvLUG6PPbtn9dm5h_9rjqDYG0HrTZ0zbg@mail.gmail.com>
2020-01-15 0:23 ` [alsa-devel] No sound since 5.4 on skl_n88l25_s4567 Kuninori Morimoto
2020-01-15 1:41 ` Pierre-Louis Bossart
2020-01-15 11:57 ` ojab //
2020-01-15 15:07 ` Pierre-Louis Bossart
2020-01-15 17:54 ` ojab //
2020-01-15 19:38 ` Pierre-Louis Bossart
2020-01-16 0:32 ` Kuninori Morimoto
2020-01-16 1:04 ` Pierre-Louis Bossart [this message]
2020-01-16 1:42 ` Kuninori Morimoto
2020-01-16 14:57 ` Mark Brown
2020-02-17 15:10 ` ojab //
2020-02-18 16:24 ` Pierre-Louis Bossart
2020-02-20 17:19 ` ojab //
2020-01-15 11:59 ` ojab //
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d0f1830-a2f0-997a-99cc-05c268acefc6@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=ojab@ojab.ru \
--cc=ranjani.sridharan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).