From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/3] ASoC: snprintf() usage fixes
Date: Tue, 18 Feb 2020 19:53:49 +0100 [thread overview]
Message-ID: <6e40ea50-7850-6040-fff8-3a22c98bb327@intel.com> (raw)
In-Reply-To: <20200218111737.14193-1-tiwai@suse.de>
On 2020-02-18 12:17, Takashi Iwai wrote:
> Hi,
>
> this is a series of patches I spotted during debugging other code.
> Intel skl and ASoC PCM core invokes succeeding calls of snprintf()
> with the incorrect expectation of the return value, which may lead to
> a buffer overflow.
>
> The first patch is yet another bug I found during working on this, and
> it's rather a real bug that can be seen clearly.
>
>
> Takashi
>
> ===
>
> Takashi Iwai (3):
> ASoC: intel: skl: Fix pin debug prints
> ASoC: intel: skl: Fix possible buffer overflow in debug outputs
> ASoC: pcm: Fix possible buffer overflow in dpcm state sysfs output
Thank you, Takashi for the fixes.
s/skl/skylake/g but I don't mind the shortcut usage at all.
For the /intel/skylake patches:
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
prev parent reply other threads:[~2020-02-18 18:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 11:17 [PATCH 0/3] ASoC: snprintf() usage fixes Takashi Iwai
2020-02-18 11:17 ` [PATCH 1/3] ASoC: intel: skl: Fix pin debug prints Takashi Iwai
2020-02-19 20:58 ` Applied "ASoC: intel: skl: Fix pin debug prints" to the asoc tree Mark Brown
2020-02-18 11:17 ` [PATCH 2/3] ASoC: intel: skl: Fix possible buffer overflow in debug outputs Takashi Iwai
2020-02-19 20:58 ` Applied "ASoC: intel: skl: Fix possible buffer overflow in debug outputs" to the asoc tree Mark Brown
2020-02-18 11:17 ` [PATCH 3/3] ASoC: pcm: Fix possible buffer overflow in dpcm state sysfs output Takashi Iwai
2020-02-19 20:58 ` Applied "ASoC: pcm: Fix possible buffer overflow in dpcm state sysfs output" to the asoc tree Mark Brown
2020-02-18 18:53 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e40ea50-7850-6040-fff8-3a22c98bb327@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).