From: "Derek [方德義]" <derek.fang@realtek.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"Albert Chen" <albertchen@realtek.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Flove(HsinFu)" <flove@realtek.com>
Subject: RE: [PATCH 1/2] ASoC: rt5682: Add CCF usage for providing I2S clks
Date: Tue, 18 Feb 2020 06:33:19 +0000 [thread overview]
Message-ID: <6f7994b39e9444eaaf269cca76104585@realtek.com> (raw)
In-Reply-To: <20200217123650.GD9304@sirena.org.uk>
> Subject: Re: [PATCH 1/2] ASoC: rt5682: Add CCF usage for providing I2S clks
>
> On Mon, Feb 17, 2020 at 10:59:55AM +0000, Derek [方德義] wrote:
> > > Subject: Re: [PATCH 1/2] ASoC: rt5682: Add CCF usage for providing I2S clks
>
> > > > + if (parent_rate != CLK_PLL2_FIN)
> > > > + dev_warn(component->dev, "clk %s only support %d Hz
> input\n",
> > > > + clk_name, CLK_PLL2_FIN);
>
> > > > + if (rate != CLK_48) {
> > > > + dev_warn(component->dev, "clk %s only support %d Hz
> output\n",
> > > > + clk_name, CLK_48);
> > > > + rate = CLK_48;
> > > > + }
>
> > > Are these genuine restrictions of the hardware or is this just being
> > > hard coded in the driver?
>
> > It's hard coded for an application case.
> > Generate a 48kHz clk with a parent 48 MHz clk.
>
> I see... obviously this is really not good quality of implementation
> although it doesn't actually break any external interfaces so I guess we
> could take it. I would at least want to see some clear comments in both
> the code and the changelog explaining that this limitation is just a
> temporary hack until a better implementation is done though.
Ok. Thanks for the advice.
I will add more comments both in the source and commit to clearly describe
the driver support and limitation, and then send the PATCH v2.
------Please consider the environment before printing this e-mail.
prev parent reply other threads:[~2020-02-18 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 7:53 [alsa-devel] [PATCH 1/2] ASoC: rt5682: Add CCF usage for providing I2S clks derek.fang
2020-02-14 7:53 ` [alsa-devel] [PATCH 2/2] ASoC: rt5682: Add DAI clock binding info for WCLK/BCLK CCF usage derek.fang
2020-02-14 12:38 ` [alsa-devel] [PATCH 1/2] ASoC: rt5682: Add CCF usage for providing I2S clks Mark Brown
[not found] ` <b9cfe003aeb34216b59c9a22c4601bf1@realtek.com>
2020-02-17 12:36 ` Mark Brown
2020-02-18 6:33 ` Derek [方德義] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f7994b39e9444eaaf269cca76104585@realtek.com \
--to=derek.fang@realtek.com \
--cc=albertchen@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).