From: Alexander Tsoy <alexander@tsoy.me>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: Apply async workaround for Scarlett 2i4 2nd gen
Date: Wed, 22 Apr 2020 06:57:03 +0300 [thread overview]
Message-ID: <7190177d62f349eea7a5d1056924a63fc4270d43.camel@tsoy.me> (raw)
In-Reply-To: <s5hpnc01vq5.wl-tiwai@suse.de>
В Вт, 21/04/2020 в 21:31 +0200, Takashi Iwai пишет:
> On Tue, 21 Apr 2020 21:09:08 +0200,
> Alexander Tsoy wrote:
> > Due to rounding error driver sometimes incorrectly calculate next
> > packet
> > size, which results in audible clicks on devices with synchronous
> > playback
> > endpoints. For example on a high speed bus and a sample rate 44.1
> > kHz it
> > loses one sample every ~40.9 seconds. Fortunately playback
> > interface on
> > Scarlett 2i4 2nd gen has a working explicit feedback endpoint, so
> > we can
> > switch playback data endpoint to asynchronous mode as a workaround.
> >
> > Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
>
> Applied now, thanks.
>
> I wonder, though, whether we can correct the rounding error in the
> driver code, too.
I'm not sure if it's possible with currently used Q16.16 arithmetic.
next prev parent reply other threads:[~2020-04-22 3:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 19:09 [PATCH] ALSA: usb-audio: Apply async workaround for Scarlett 2i4 2nd gen Alexander Tsoy
2020-04-21 19:31 ` Takashi Iwai
2020-04-22 3:57 ` Alexander Tsoy [this message]
2020-04-22 18:55 ` Gregor Pintar
2020-04-22 19:26 ` Alexander Tsoy
2020-04-22 20:19 ` Alexander Tsoy
2020-04-22 20:28 ` Takashi Iwai
2020-04-22 23:45 ` Alexander Tsoy
2020-04-23 7:22 ` Takashi Iwai
2020-04-23 11:22 ` Takashi Iwai
2020-04-23 15:10 ` Alexander Tsoy
2020-04-23 16:57 ` Alexander Tsoy
2020-04-23 17:29 ` Takashi Iwai
2020-04-23 17:35 ` Takashi Iwai
2020-04-23 18:24 ` Alexander Tsoy
2020-04-26 17:12 ` Alexander Tsoy
2020-04-27 7:08 ` Takashi Iwai
2020-04-23 17:32 ` Takashi Iwai
2020-04-23 11:46 ` Gregor Pintar
2020-04-23 14:01 ` Alexander Tsoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7190177d62f349eea7a5d1056924a63fc4270d43.camel@tsoy.me \
--to=alexander@tsoy.me \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).