From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C0DC352BE for ; Sat, 18 Apr 2020 18:56:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E9D621D93 for ; Sat, 18 Apr 2020 18:56:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Y5KkDRA0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZSd4gPvR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E9D621D93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BEC481660; Sat, 18 Apr 2020 20:55:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BEC481660 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587236203; bh=EsoNIyw53b+Su18wZ/HhqYx525Bl0vkHrQil9p2VruE=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y5KkDRA0Y/LzS5FTp9X458K7R2z+0FnbCDtUcthA/N4yPRaFCyEA8YmnOa5cGFcAU phAwaRTQc3NHQTiSVdFgWybKZcPsbZN5TvA+4fwxVNx2sZWzxnjZ+b7O2aghhbGjZE hgaNHLucWlxoicWoghR444B+O/LC9kvnrJXIaLFk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 54E1DF8013D; Sat, 18 Apr 2020 20:55:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 10B5AF8012E; Sat, 18 Apr 2020 20:55:52 +0200 (CEST) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2F22AF8012E for ; Sat, 18 Apr 2020 20:55:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2F22AF8012E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZSd4gPvR" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=Fw5l4YeyjM9q5bGtc9HETB0eI3KSL+di5A5JibSeUVA=; b=ZSd4gPvRX+1EcEyWBtmo2xeq+k YGKz4bmzRQ0lBLMGURF5oh6CYWK4W10L7kKdDnAI5hJvRsl3/cWENuwUZYgrll4QOeY8IG2KAIwKm DmODoHeVwqhNbpPD2mueD4eauFer8yFIuqk42bawnd9he64bV/jQfHVxkRxNmOAMcICHspMdvF49L mwjxdxSsr1vLxgUV9OSBDAPsxY5sxHKI3ovi3k6+D0MPLbEOgd5u2ipYWdww6+1xj13RRsP3BbZTP 5/uu3l5yRFjedkT+1vldVo7jjG4LvH/c3xDAix8dZm74bZ5+P4Sk4RUlA1MpmcdYVcPWYAQRtLCOh CMd3C1UQ==; Received: from [2601:1c0:6280:3f0::19c2] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPscv-0000Nr-Nv; Sat, 18 Apr 2020 18:55:41 +0000 Subject: Re: [PATCH 2/9] fs: fix empty-body warning in posix_acl.c To: Linus Torvalds References: <20200418184111.13401-1-rdunlap@infradead.org> <20200418184111.13401-3-rdunlap@infradead.org> From: Randy Dunlap Message-ID: <722a746a-1438-60e3-04b2-c13eda2ad168@infradead.org> Date: Sat, 18 Apr 2020 11:55:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Dmitry Torokhov , Zzy Wysm , Linux Kernel Mailing List , "J. Bruce Fields" , target-devel , Dave Jiang , linux-scsi , linux-nvdimm , Vishal Verma , linux-input@vger.kernel.org, Alexander Viro , Dan Williams , Andrew Morton , "open list:NFS, SUNRPC, AND..." , "Martin K. Petersen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Takashi Iwai , Chuck Lever , linux-fsdevel , Johannes Berg X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 4/18/20 11:53 AM, Linus Torvalds wrote: > On Sat, Apr 18, 2020 at 11:41 AM Randy Dunlap wrote: >> >> Fix gcc empty-body warning when -Wextra is used: > > Please don't do this. > > First off, "do_empty()" adds nothing but confusion. Now it > syntactically looks like it does something, and it's a new pattern to > everybody. I've never seen it before. > > Secondly, even if we were to do this, then the patch would be wrong: > >> if (cmpxchg(p, ACL_NOT_CACHED, sentinel) != ACL_NOT_CACHED) >> - /* fall through */ ; >> + do_empty(); /* fall through */ > > That comment made little sense before, but it makes _no_ sense now. > > What fall-through? I'm guessing it meant to say "nothing", and > somebody was confused. With "do_empty()", it's even more confusing. > > Thirdly, there's a *reason* why "-Wextra" isn't used. > > The warnings enabled by -Wextra are usually complete garbage, and > trying to fix them often makes the code worse. Exactly like here. OK, no problem. That's why PATCH 0/9 says RFC. Oops. Crap. It was *supposed* to say RFC. :( -- ~Randy