From: chunxu.li <chunxu.li@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
daniel.baluta@nxp.com, tinghan.shen@mediatek.com,
pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com,
project_global_chrome_upstream_group@mediatek.com,
linux-mediatek@lists.infradead.org, yc.hung@mediatek.com,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
peter.ujfalusi@linux.intel.com,
linux-arm-kernel@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine_select field for mt8186
Date: Thu, 4 Aug 2022 22:47:48 +0800 [thread overview]
Message-ID: <767ff0f7f40711b8ecda545e43e87036e88f0f22.camel@mediatek.com> (raw)
In-Reply-To: <YuvKjn3cW5im2Yw9@sirena.org.uk>
On Thu, 2022-08-04 at 14:33 +0100, Mark Brown wrote:
> On Thu, Aug 04, 2022 at 09:21:37PM +0800, chunxu.li wrote:
> > On Thu, 2022-08-04 at 13:41 +0100, Mark Brown wrote:
> > > On Thu, Aug 04, 2022 at 05:13:59PM +0800, Chunxu Li wrote:
> > > > + .board = "mediatek,mt8186",
> > > > + .sof_tplg_filename = "sof-mt8186.tplg",
> > > The mediatek,mt8186 compatible looks like a SoC compatible not a
> > > board
> > > compatible...
> > Our dts config as below:
> > kingler board:
> > compatible = "google,corsola", "google,kingler", "mediatek,mt8186";
> > krabby board:
> > compatible = "google,corsola", "google,krabby", "mediatek,mt8186";
>
> So the SoC is listed as a fallback for the board and things work out
> fine.
>
> > Which of the two approaches do you prefer?
>
> I think it would be clearer to keep what's being matched the same but
> rename the .board field to be .compatible, or possibly
> .system_compatible
> or something if it's unclear what's being matched. That'd be more
> normal for specifying a compatible string anyway.
Appreciated for you advice, I'll rename the .board to .compatible as
following:
+ .compatible = "mediatek,mt8186",
+ .sof_tplg_filename = "sof-mt8186.tplg",
prev parent reply other threads:[~2022-08-04 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:13 [PATCH 0/2] ASoC: SOF: Introduce of_machine_select Chunxu Li
2022-08-04 9:13 ` [PATCH 1/2] ASoC: SOF: Introduce optional callback of_machine_select Chunxu Li
2022-08-04 13:17 ` Mark Brown
2022-08-04 14:36 ` chunxu.li
2022-08-04 14:59 ` Mark Brown
2022-08-04 9:13 ` [PATCH 2/2] ASoC: SOF: mediatek: Add .of_machine_select field for mt8186 Chunxu Li
2022-08-04 12:41 ` Mark Brown
2022-08-04 13:21 ` chunxu.li
2022-08-04 13:33 ` Mark Brown
2022-08-04 14:47 ` chunxu.li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=767ff0f7f40711b8ecda545e43e87036e88f0f22.camel@mediatek.com \
--to=chunxu.li@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=project_global_chrome_upstream_group@mediatek.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tinghan.shen@mediatek.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).