From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45636C433DF for ; Thu, 9 Jul 2020 03:48:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A666020774 for ; Thu, 9 Jul 2020 03:48:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pcqzEU2F"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="tGwbDeAH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A666020774 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 26F02950; Thu, 9 Jul 2020 05:47:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 26F02950 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594266489; bh=3K0GaDPiam8+sEUbvbjfKqj6W4SooylqboUppAbZxfk=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pcqzEU2FSfRCUiL3IBeTAXxhM1IaWZIKymC1OPZxVCqG+s3wLsdXZrJS6j+R5y8lk rfNwg6wA6VTOWM9JgnaMVuvcPgjJ4OwH9l9DOJ0inb0yBW16OppwUHVSXX2XLZ+HyM NLwIeugtXDOxXKUEaPzl7bKIdOyyv1t9A16x+kMU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 83888F8011F; Thu, 9 Jul 2020 05:47:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 33F67F80216; Thu, 9 Jul 2020 05:47:16 +0200 (CEST) Received: from mail29.static.mailgun.info (mail29.static.mailgun.info [104.130.122.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9F3DBF8011F for ; Thu, 9 Jul 2020 05:47:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9F3DBF8011F Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="tGwbDeAH" DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594266430; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=ClVKfwV1sejEfp520mgp/j3raQqoqw5b6t+T4bASRgo=; b=tGwbDeAHeUHnGiOmkeRsHQckPwF1fEVenDuoBarQ8esBAT5SGrXUJV8SEWz4v+DjIPBFetV/ ATM2renfFjknuetvmOX3cSaIrNIAvKzzB047KT84dHpHix2jHM83h8glOlXvRgxFGaF5usq3 /Tju+FZiueOv7ngUL/vU310jDt8= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI4ZmE2ZSIsICJhbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5f069319945d3440ee272695 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 09 Jul 2020 03:46:33 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 89576C433CA; Thu, 9 Jul 2020 03:46:32 +0000 (UTC) Received: from [192.168.0.129] (unknown [183.83.142.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rohitkr) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0F3ADC433C6; Thu, 9 Jul 2020 03:46:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0F3ADC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=rohitkr@codeaurora.org Subject: Re: [PATCH v3 5/8] ASoC: qcom: lpass-platform: Replace card->dev with component->dev To: Mark Brown References: <1594184896-10629-1-git-send-email-rohitkr@codeaurora.org> <1594184896-10629-6-git-send-email-rohitkr@codeaurora.org> <20200708165041.GX4655@sirena.org.uk> From: Rohit Kumar Message-ID: <79221e43-c4f0-8e75-e97e-f0f255f3f68c@codeaurora.org> Date: Thu, 9 Jul 2020 09:16:11 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200708165041.GX4655@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, linux-arm-msm@vger.kernel.org, plai@codeaurora.org, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, srinivas.kandagatla@linaro.org, Ajit Pandey , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/8/2020 10:20 PM, Mark Brown wrote: > On Wed, Jul 08, 2020 at 10:38:13AM +0530, Rohit kumar wrote: >> From: Ajit Pandey >> >> We are allocating dma memory for component->dev but trying to mmap >> such memory for substream->pcm->card->dev. Replace device argument >> in mmap with component->dev to fix this. > This is a bug fix and should've been at the start of the series (or sent > separately) so that it can be applied without the rest of the series. Thanks Mark for the suggestion. I will send it separately. For other patches in series, I will wait for comments before posting next patchset. Thanks, Rohit -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.