alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Jack Yu <jack.yu@realtek.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"kent_chen@realtek.com [陳建宏]" <kent_chen@realtek.com>,
	陳昶志 <kenny_chen@realtek.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"Derek [方德義]" <derek.fang@realtek.com>,
	"Shuming [范書銘]" <shumingf@realtek.com>,
	"Mingjane Hsieh" <mingjane_hsieh@realtek.com>,
	"Flove(HsinFu)" <flove@realtek.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: rt1015: fix typo for bypass boost control
Date: Fri, 14 Feb 2020 09:28:19 +0000	[thread overview]
Message-ID: <7a6ad579cc9044778d8d515d24a2b448@realtek.com> (raw)
In-Reply-To: <20200213210404.GM4333@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

Hi Mark,

I've generated the patch again from latest "for-next" branch but still get the same patch like attached file,
not sure what's wrong with this patch? Could you please help specify what's wrong with this patch?
Thank you very much!

Regards,
Jack



> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Friday, February 14, 2020 5:04 AM
> To: Jack Yu
> Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de;
> Flove(HsinFu); 陳昶志; kent_chen@realtek.com [陳建宏]; Mingjane Hsieh;
> Oder Chiou; Shuming [范書銘]; Derek [方德義]
> Subject: Re: [PATCH] ASoC: rt1015: fix typo for bypass boost control
> 
> On Wed, Feb 12, 2020 at 01:59:49AM +0000, Jack Yu wrote:
> > Fix typo for "Bypass Boost" control.
> 
> This doesn't apply against current code, please check and resend.  Also
> this is more of a cut'n'paste error than a typo.
> 
> ------Please consider the environment before printing this e-mail.

[-- Attachment #2: 0001-ASoC-rt1015-fix-typo-for-bypass-boost-control.patch --]
[-- Type: application/octet-stream, Size: 1638 bytes --]

From 69d66cd098bef69e12ffc39669fd1c806838162c Mon Sep 17 00:00:00 2001
From: Jack Yu <jack.yu@realtek.com>
Date: Fri, 14 Feb 2020 17:04:40 +0800
Subject: [PATCH v2] ASoC: rt1015: fix typo for bypass boost control

Fix typo for "Bypass Boost" control.

Signed-off-by: Jack Yu <jack.yu@realtek.com>
---
 sound/soc/codecs/rt1015.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/rt1015.c b/sound/soc/codecs/rt1015.c
index 6d490e2dbc25..d300b417dd50 100644
--- a/sound/soc/codecs/rt1015.c
+++ b/sound/soc/codecs/rt1015.c
@@ -444,7 +444,7 @@ static int rt1015_boost_mode_put(struct snd_kcontrol *kcontrol,
 	return 0;
 }
 
-static int rt5518_bypass_boost_get(struct snd_kcontrol *kcontrol,
+static int rt1015_bypass_boost_get(struct snd_kcontrol *kcontrol,
 		struct snd_ctl_elem_value *ucontrol)
 {
 	struct snd_soc_component *component =
@@ -457,7 +457,7 @@ static int rt5518_bypass_boost_get(struct snd_kcontrol *kcontrol,
 	return 0;
 }
 
-static int rt5518_bypass_boost_put(struct snd_kcontrol *kcontrol,
+static int rt1015_bypass_boost_put(struct snd_kcontrol *kcontrol,
 		struct snd_ctl_elem_value *ucontrol)
 {
 	struct snd_soc_component *component =
@@ -497,7 +497,7 @@ static const struct snd_kcontrol_new rt1015_snd_controls[] = {
 		rt1015_boost_mode_get, rt1015_boost_mode_put),
 	SOC_ENUM("Mono LR Select", rt1015_mono_lr_sel),
 	SOC_SINGLE_EXT("Bypass Boost", SND_SOC_NOPM, 0, 1, 0,
-		rt5518_bypass_boost_get, rt5518_bypass_boost_put),
+		rt1015_bypass_boost_get, rt1015_bypass_boost_put),
 };
 
 static int rt1015_is_sys_clk_from_pll(struct snd_soc_dapm_widget *source,
-- 
2.25.0


[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2020-02-14  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2fe07b2c200f43bc81de61f4e6c780ac@realtek.com>
2020-02-13 21:04 ` [alsa-devel] [PATCH] ASoC: rt1015: fix typo for bypass boost control Mark Brown
2020-02-14  9:28   ` Jack Yu [this message]
2020-02-14 11:51     ` Mark Brown
     [not found] <718b2de2f61a4fa1ad8099a55d11c6fc@realtek.com>
2020-02-11 11:46 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a6ad579cc9044778d8d515d24a2b448@realtek.com \
    --to=jack.yu@realtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=kenny_chen@realtek.com \
    --cc=kent_chen@realtek.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=mingjane_hsieh@realtek.com \
    --cc=oder_chiou@realtek.com \
    --cc=shumingf@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).