From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Cheng-Yi Chiang <cychiang@chromium.org>, linux-kernel@vger.kernel.org
Cc: Taniya Das <tdas@codeaurora.org>,
alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
Heiko Stuebner <heiko@sntech.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Rohit kumar <rohitkr@codeaurora.org>,
Patrick Lai <plai@codeaurora.org>,
linux-rockchip@lists.infradead.org,
Andy Gross <agross@kernel.org>,
dgreid@chromium.org, devicetree@vger.kernel.org,
tzungbi@chromium.org, Srinivasa Rao <srivasam@codeaurora.org>,
Stephan Gerhold <stephan@gerhold.net>,
linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-kernel@lists.infradead.org, dianders@chromium.org,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings
Date: Tue, 13 Oct 2020 11:36:33 +0100 [thread overview]
Message-ID: <7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org> (raw)
In-Reply-To: <20200914080619.4178587-3-cychiang@chromium.org>
Hi Cheng,
Sorry for such late review w.r.t compatibles,
On 14/09/2020 09:06, Cheng-Yi Chiang wrote:
> +---
> +$id:http://devicetree.org/schemas/sound/qcom,sc7180.yaml#
> +$schema:http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver
> +
> +maintainers:
> + - Rohit kumar<rohitkr@codeaurora.org>
> + - Cheng-Yi Chiang<cychiang@chromium.org>
> +
> +description:
> + This binding describes the SC7180 sound card which uses LPASS for audio.
> +
> +properties:
> + compatible:
> + const: qcom,sc7180-sndcard-rt5682-m98357-1mic
This information can come from the dai link description itself, why
should compatible string have this information?
Can't we have better compatible string with actual board name or use the
same compatible name as used by other boards?
Can you give us some details on the advantages of doing this way?
Or am I missing something?
AFAIU, you should add proper board name / model name to the compatible
string rather than describe how its connected. Connection is already
part of dai link definition.
On the other hand model property can include variant information.
This can also be used to set card long name which will help in UCM2.
The reason I had to bring this up is because the use-space (ucm in this
case) will not be in a position to differentiate between different board
variants to select correct mixer controls, so its going to be a pain!
Thanks,
srini
next prev parent reply other threads:[~2020-10-13 10:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 8:06 [PATCH v11 0/3] Add documentation and machine driver for SC7180 sound card Cheng-Yi Chiang
2020-09-14 8:06 ` [PATCH v11 1/3] ASoC: hdmi-codec: Use set_jack ops to set jack Cheng-Yi Chiang
2020-09-14 8:06 ` [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings Cheng-Yi Chiang
2020-09-14 17:48 ` Rob Herring
2020-09-15 12:44 ` Cheng-yi Chiang
2020-10-13 3:46 ` Cheng-yi Chiang
2020-10-13 10:36 ` Srinivas Kandagatla [this message]
2020-10-15 7:59 ` Cheng-yi Chiang
2020-10-15 16:12 ` Mark Brown
2020-10-20 13:37 ` Cheng-yi Chiang
2020-10-20 14:37 ` Mark Brown
2020-10-20 14:55 ` Srinivas Kandagatla
2020-10-20 18:54 ` Cheng-yi Chiang
2020-10-21 12:00 ` Srinivas Kandagatla
2020-10-21 12:39 ` Mark Brown
2020-10-22 3:29 ` Tzung-Bi Shih
2020-10-22 10:12 ` Srinivas Kandagatla
2020-10-20 18:51 ` Cheng-yi Chiang
2020-10-20 19:39 ` Mark Brown
2020-09-14 8:06 ` [PATCH v11 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration Cheng-Yi Chiang
2020-10-13 3:50 ` Cheng-yi Chiang
2020-10-15 8:02 ` Cheng-yi Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bdc0d63-27b1-f99e-c5f8-65f880733d16@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srivasam@codeaurora.org \
--cc=stephan@gerhold.net \
--cc=tdas@codeaurora.org \
--cc=tiwai@suse.com \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).