From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEFAC433DB for ; Thu, 11 Mar 2021 14:30:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7718F64FE2 for ; Thu, 11 Mar 2021 14:30:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7718F64FE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E0423188B; Thu, 11 Mar 2021 15:29:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E0423188B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1615473036; bh=PsPXywahhWOfgQoroDvh+MNKMahX0rcklzpqXX1Uru8=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Snmr1hILb4chV4ATkTzw1g1WethnMqPsJH/JaJg5HNpcAdcBONwchPNB7Sq+gZB2w z80wNQGZKAInKNypV+iTE3R+n+5ACRbtX+//v4vczYrg17ci8ALXCnyv8cxh47GBNG zWmIrmfTig3Gh1IATFNQU0mIfEpcjYnoqk5juvKE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 943D3F80227; Thu, 11 Mar 2021 15:29:42 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0CF57F8028B; Thu, 11 Mar 2021 15:29:36 +0100 (CET) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4A4DBF800BF for ; Thu, 11 Mar 2021 15:29:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4A4DBF800BF Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rkspiYjV" Received: by mail-wm1-x329.google.com with SMTP id 124-20020a1c00820000b029010b871409cfso13316878wma.4 for ; Thu, 11 Mar 2021 06:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/vz8gDl5MDjPbVH9KHrcAUmn27/O+atbsXWhS4lWsKY=; b=rkspiYjV9FNKkmFIzQEaFCJvgVJY7z8ZsTZNzkb2vVudwYf1iZ0zUDwnwWGoVg4N1X HxUrw8jG5SGEwXk5/Yye9e53FtYyUWdIdO5svT34ktoow03b1fWqVQAA2sN8mnGhfg67 fqOW5xjGN+yZTy7qbosES/rU3GGiD8dLVrDPyZ6w+3bF1H+WIuMgALLEOY65ItSdmWWt aorWyhispmczKIoT5mXNjLZzLMAkD5GU4Jh4GaFRdENlKxRiX0oTpK4mXBmB9eBPxnxp qVMLQFdhUMLlqK6FpcybMfb662hWDbZ2YqjZMGfABVZh7IPv0wcOHudnCzZul4o64nbO ftCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/vz8gDl5MDjPbVH9KHrcAUmn27/O+atbsXWhS4lWsKY=; b=YYaJBnh8dp8zyyjB0Zb4tsdG35L34Vfs58Ok06bTwIQSRl6wujDH7w9EiD76DRCk9s RZlrnSdsWClLyhI+WYvWddqA0+HPKXQIB1XuGiylT9kDWijjGQambnCOuYgrDXheWYYI WeTcH8Wc1ZbNcizTXWbNGCfMMJWjvxOgj7raNhUTZMry0wAKL98oex955zNHijwrYS8L 0e00AEe3WA46A+g2w3bEpRhKYnFFu7IMBQnrdX5cxeZYr6wCbjOxGxOWapbgAn0Oy3cp lmywxKsc5TzofvEHmlvfT7YIT0JynOksfU3ZUPu9+92a1dyfQ5JnXp0fJU+G/xDP8yRy iNog== X-Gm-Message-State: AOAM533CoHTj37YagZ/yVxSywycAVhDASXZBX59WHh86lnOZv0i4WNPv xeece9045NAQD+UNolZ2jBJrkZ3gSNvN/w== X-Google-Smtp-Source: ABdhPJz/f31hwubqZ9UY9m+xvMvxdfSlERJS3s8jXE1Y0O3cu/XJz/lC0iqov+wtSlX3rhWj4sLoIQ== X-Received: by 2002:a1c:4c10:: with SMTP id z16mr8472110wmf.136.1615472961081; Thu, 11 Mar 2021 06:29:21 -0800 (PST) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id r11sm4295425wrm.26.2021.03.11.06.29.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Mar 2021 06:29:20 -0800 (PST) Subject: Re: [PATCH v2 2/5] soundwire: qcom: update port map allocation bit mask To: Pierre-Louis Bossart , broonie@kernel.org, vkoul@kernel.org References: <20210309141514.24744-1-srinivas.kandagatla@linaro.org> <20210309141514.24744-3-srinivas.kandagatla@linaro.org> <50c83be0-8948-8450-4b91-d43cc97f8640@linux.intel.com> From: Srinivas Kandagatla Message-ID: <7f13d7c1-b61a-fd19-92b7-99ccc957750c@linaro.org> Date: Thu, 11 Mar 2021 14:29:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <50c83be0-8948-8450-4b91-d43cc97f8640@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: robh@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 09/03/2021 15:55, Pierre-Louis Bossart wrote: > > > On 3/9/21 8:15 AM, Srinivas Kandagatla wrote: >> currently the internal bitmask used for allocating ports starts with >> offset 0. >> This is bit confusing as data port numbers on Qualcomm controller are >> valid >> from 1 to 14. So adjust this bit mask accordingly, this will also help >> while >> adding static port map support. >> >> Signed-off-by: Srinivas Kandagatla >> --- >>   drivers/soundwire/qcom.c | 11 +++++++---- >>   1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c >> index 6d22df01f354..f4f1c5f2af0b 100644 >> --- a/drivers/soundwire/qcom.c >> +++ b/drivers/soundwire/qcom.c >> @@ -519,7 +519,7 @@ static void qcom_swrm_stream_free_ports(struct >> qcom_swrm_ctrl *ctrl, >>               port_mask = &ctrl->din_port_mask; >>           list_for_each_entry(p_rt, &m_rt->port_list, port_node) >> -            clear_bit(p_rt->num - 1, port_mask); >> +            clear_bit(p_rt->num, port_mask); >>       } >>       mutex_unlock(&ctrl->port_lock); >> @@ -552,13 +552,13 @@ static int qcom_swrm_stream_alloc_ports(struct >> qcom_swrm_ctrl *ctrl, >>               list_for_each_entry(p_rt, &s_rt->port_list, port_node) { >>                   /* Port numbers start from 1 - 14*/ >>                   pn = find_first_zero_bit(port_mask, maxport); >> -                if (pn > (maxport - 1)) { >> +                if (pn > (maxport)) { > > nit-pick: useless parentheses I agree, will remove this and address the other comment too in next spin! --srini > >>                       dev_err(ctrl->dev, "All ports busy\n"); >>                       ret = -EBUSY; >>                       goto err; >>                   } >>                   set_bit(pn, port_mask); >> -                pconfig[nports].num = pn + 1; >> +                pconfig[nports].num = pn; >>                   pconfig[nports].ch_mask = p_rt->ch_mask; >>                   nports++; >>               } >> @@ -580,7 +580,7 @@ static int qcom_swrm_stream_alloc_ports(struct >> qcom_swrm_ctrl *ctrl, >>   err: >>       if (ret) { >>           for (i = 0; i < nports; i++) >> -            clear_bit(pconfig[i].num - 1, port_mask); >> +            clear_bit(pconfig[i].num, port_mask); >>       } >>       mutex_unlock(&ctrl->port_lock); >> @@ -754,6 +754,9 @@ static int qcom_swrm_get_port_config(struct >> qcom_swrm_ctrl *ctrl) >>       ctrl->num_dout_ports = val; >>       nports = ctrl->num_dout_ports + ctrl->num_din_ports; >> +    /* port numbers are non zero, so mark port 0 */ > > mask? > >> +    set_bit(0, &ctrl->dout_port_mask); >> +    set_bit(0, &ctrl->din_port_mask); >>       ret = of_property_read_u8_array(np, "qcom,ports-offset1", >>                       off1, nports); >>