From: Jaroslav Kysela <perex@perex.cz>
To: Phil Burk <philburk@google.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Baolin Wang <baolin.wang@linaro.org>,
Takashi Iwai <tiwai@suse.de>, Zach Riggle <riggle@google.com>,
Mark Brown <broonie@kernel.org>, Leo Yan <leo.yan@linaro.org>
Subject: Re: [PATCH 0/2 v4] ALSA: pcm: anonymous dup implementation
Date: Thu, 7 Feb 2019 18:53:14 +0100 [thread overview]
Message-ID: <860bd8b7-2ba1-2cc8-52e2-dacedd58eb05@perex.cz> (raw)
In-Reply-To: <CACL=Q7wpCJiiHoWE7FrArpm0DFYKUkLdPkUg+uh9=oOMPWWWMA@mail.gmail.com>
Dne 7.2.2019 v 18:41 Phil Burk napsal(a):
> Thanks for these patches for tinyalsa. Looks great!
>
> I made a few minor comments on the code layout.
> https://github.com/perexg/tinyalsa/commit/f62b953f37693e8426ee4c20e53baae757ba1026
> Can you see them?
Yes, I updated the anondup branch with the suggested changes (except the
else comment which I don't understand - it's just copy-n-paste of the
origin).
Thanks,
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-02-07 17:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 9:39 [PATCH 0/2 v4] ALSA: pcm: anonymous dup implementation Jaroslav Kysela
2019-02-04 9:39 ` [PATCH 1/2] ALSA: pcm: implement the anonymous dup (inode file descriptor) Jaroslav Kysela
2019-02-04 9:39 ` [PATCH 2/2] ALSA: pcm: implement the mmap buffer mode for the anonymous dup Jaroslav Kysela
2019-02-04 10:48 ` Takashi Iwai
2019-02-07 17:41 ` [PATCH 0/2 v4] ALSA: pcm: anonymous dup implementation Phil Burk
2019-02-07 17:53 ` Jaroslav Kysela [this message]
2019-02-08 15:57 ` Phil Burk
2019-03-26 14:09 ` Mark Brown
2019-03-26 14:13 ` Takashi Iwai
2019-03-26 14:27 ` Phil Burk
2019-03-26 14:41 ` Jaroslav Kysela
2019-04-23 18:08 ` Takashi Iwai
2019-04-23 20:11 ` Phil Burk
2019-04-23 20:25 ` Takashi Iwai
2020-06-08 13:45 ` Mark Brown
2020-06-08 17:49 ` Phil Burk
2020-06-10 23:10 ` Phil Burk
2020-06-12 16:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=860bd8b7-2ba1-2cc8-52e2-dacedd58eb05@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=leo.yan@linaro.org \
--cc=philburk@google.com \
--cc=riggle@google.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).