From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT	parameter handling
Date: Tue, 11 Mar 2014 21:07:15 -0700 (PDT)
Message-ID: <871ty8rrf3.wl%kuninori.morimoto.gx@gmail.com>
References: <cover.1394451329.git.jsarha@ti.com>
	<877g80rzgg.wl%kuninori.morimoto.gx@gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-omap-owner@vger.kernel.org>
In-Reply-To: <877g80rzgg.wl%kuninori.morimoto.gx@gmail.com>
Sender: linux-omap-owner@vger.kernel.org
To: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Cc: Jyri Sarha <jsarha@ti.com>, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, liam.r.girdwood@linux.intel.com, detheridge@ti.com, peter.ujfalusi@ti.com, broonie@kernel.org, bcousson@baylibre.com, Nicolin Chen <Guangyu.Chen@freescale.com>
List-Id: alsa-devel@alsa-project.org


Hi Mark, Jyri

> > Since RFC:
> > - fixed commit msg typo
> > - added include/sound/soc.h changes too
> > 
> > The sematics of bitclock-master and frame-master DT parameters
> > should depend on whether they are found from a cpu-dai or codec
> > sub-node.
> > 
> > - bitclock-master in cpu-dai node means Codec-Bitclock-Slave
> > - frame-master in cpu-dai node means Codec-Frame-Slave
> > - bitclock-master in codec node means Codec-Bitclock-Master
> > - frame-master in codec node means Codec-Frame-Master
> > 
> > For example in a cpu-dai mode bitclock-master parameter should produce
> > SND_SOC_DAIFMT_CBS_* daifmt flags and a codec node
> > SND_SOC_DAIFMT_CBM_* flags.

I had misunderstood about SND_SOC_DAIFMT_xxx
So, please ignore my previous comment.

But, I wounder, if cpu/codec use identical format flags,
then, asoc_simple_dai don't need fmt ?

struct asoc_simple_dai {
	const char *name;
	unsigned int fmt;       <= we can/should remove this ?
	unsigned int sysclk;
};