From: Jaroslav Kysela <perex@perex.cz>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 0/4] ucm2: Add support to SDM845 based platforms
Date: Mon, 30 Mar 2020 16:19:40 +0200 [thread overview]
Message-ID: <8732f355-adff-3a28-34b3-a85a027f297e@perex.cz> (raw)
In-Reply-To: <41e83744-5164-7cbb-98e6-fb8504c6b44e@linaro.org>
Dne 30. 03. 20 v 16:10 Srinivas Kandagatla napsal(a):
> Hi Jaroslav,
>
> On 05/03/2020 13:44, Srinivas Kandagatla wrote:
>> This patchset adds UCM support for WSA881x, WCD934x codec and two platforms,
>> DB845c DragonBoard and Lenovo YOGA C360 Laptop that use these codecs.
>>
>> Tested on Ubuntu 20.04 with pulseaudio 13 along with
>> with this fix
>> https://github.com/pulseaudio/pulseaudio/commit/cabd387e26b5fe03661f4b894826c7c6b58d7efa
>>
>
> Are you okay to pick these ucm2 patches?
Hi,
it seems that those changes does not pass through the ucm validator
(https://github.com/alsa-project/alsa-tests - python/ucm-validator directory).
I have also some comments, but I would probably prefer to create a pull
request on github to do the review for all files with history.
Thank you,
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2020-03-30 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 13:44 [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
2020-03-05 13:44 ` [PATCH 1/4] ucm2: codecs: wcd934x: Add Codec sequences Srinivas Kandagatla
2020-03-05 13:44 ` [PATCH 2/4] ucm2: codecs: wsa881x: add codec sequences Srinivas Kandagatla
2020-03-05 13:44 ` [PATCH 3/4] ucm2: DB845c: Add ucm for DB845c board Srinivas Kandagatla
2020-03-05 13:44 ` [PATCH 4/4] ucm2: Add ucm for Lenovo-YOGA-C630-13Q50 laptop Srinivas Kandagatla
2020-03-30 14:10 ` [PATCH 0/4] ucm2: Add support to SDM845 based platforms Srinivas Kandagatla
2020-03-30 14:19 ` Jaroslav Kysela [this message]
2020-03-30 14:25 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8732f355-adff-3a28-34b3-a85a027f297e@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).