From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFA32C432C0 for ; Wed, 27 Nov 2019 06:52:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45852206F0 for ; Wed, 27 Nov 2019 06:52:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="o+1e1i9R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45852206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8948B1719; Wed, 27 Nov 2019 07:51:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8948B1719 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1574837519; bh=bUSEuca0aKhO2fcpFl/39eOevwsazD23GOO99JSjBOw=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=o+1e1i9RI8bIjj56Pb4oJ/sIyug17h+TDMPFWrUtiSgzNd+qYCBu5hfhxGcMF+9tL 4khtfpzg22CwNc/Fro7Pf11xUTvwLW4nlqFkP/J/OImJrfLyWhGDaf5xKhIghONHn3 J7/jxmRiNdhpm9pxVlpF1mLvUoMEBvv/cqZeTtPw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 174EDF8013B; Wed, 27 Nov 2019 07:48:30 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 931D3F8014D; Wed, 27 Nov 2019 07:48:28 +0100 (CET) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 9A52DF800E9 for ; Wed, 27 Nov 2019 07:48:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9A52DF800E9 Date: 27 Nov 2019 15:48:19 +0900 X-IronPort-AV: E=Sophos;i="5.69,248,1571670000"; d="scan'208";a="32573211" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 27 Nov 2019 15:48:19 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 8F4A0400C44F; Wed, 27 Nov 2019 15:48:19 +0900 (JST) Message-ID: <8736e93jd8.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart In-Reply-To: <8b7a2bc1-6d89-ea18-0816-70448cbf9cb0@linux.intel.com> References: <877e3og50x.wl-kuninori.morimoto.gx@renesas.com> <87pnhgeqc2.wl-kuninori.morimoto.gx@renesas.com> <8b7a2bc1-6d89-ea18-0816-70448cbf9cb0@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA , Mark Brown Subject: Re: [alsa-devel] [PATCH v2 12/15] ASoC: soc-core: add missing return value check for soc_link_init() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > > index 79a4753..bdae48e 100644 > > --- a/sound/soc/soc-core.c > > +++ b/sound/soc/soc-core.c > > @@ -1983,8 +1983,11 @@ static int snd_soc_bind_card(struct snd_soc_card *card) > > goto probe_end; > > } > > - for_each_card_rtds(card, rtd) > > - soc_link_init(card, rtd); > > + for_each_card_rtds(card, rtd) { > > + ret = soc_link_init(card, rtd); > > + if (ret < 0) > > + goto probe_end; > > + } > > Morimoto-san, this patch proves very useful to avoid a kernel oops > when a dailink init fails, but I still see a warning when cleaning-up. > > I was experimenting with a topology file that wasn't complete and came > across the warning below, would you have any ideas/recommendations on > what might be missing? I am running out of time this week so thought I > would ask, in case this rings a bell. > > Thanks! > > [ 21.098662] bytcr_rt5640 bytcr_rt5640: ASoC: no source widget found > for modem_out > [ 21.098677] bytcr_rt5640 bytcr_rt5640: ASoC: Failed to add route > modem_out -> direct -> ssp0 Tx > [ 21.098694] bytcr_rt5640 bytcr_rt5640: ASoC: no sink widget found > for modem_in > [ 21.098703] bytcr_rt5640 bytcr_rt5640: ASoC: Failed to add route > ssp0 Rx -> direct -> modem_in > [ 21.098732] bytcr_rt5640 bytcr_rt5640: ASoC: failed to init > SSP2-Codec: -19 Do you mean, it could save you from Oops, but you still have warning ? It seems soc-dapm::snd_soc_dapm_add_routes() failed. Your kernel is missing widget route/path ? Or, sound card driver has some issue ? I have been faced this error many times. I don't remember detail, but, if my memory was correct, it was always card driver setup timing, or missing something, in my case. Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel