From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: simple-card: overwrite DAIFMT_MASTER of	cpu_dai->fmt
Date: Tue, 11 Mar 2014 21:01:05 -0700 (PDT)
Message-ID: <8738iorrpd.wl%kuninori.morimoto.gx@gmail.com>
References: <1394542472-16580-1-git-send-email-Guangyu.Chen@freescale.com>
	<8761nkryky.wl%kuninori.morimoto.gx@gmail.com>
	<20140312014927.GK28112@sirena.org.uk>
	<874n34rsul.wl%kuninori.morimoto.gx@gmail.com>
	<20140312032657.GF1177@MrMyself>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20140312032657.GF1177@MrMyself>
Sender: linux-kernel-owner@vger.kernel.org
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: Mark Brown <broonie@kernel.org>, moinejf@free.fr, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, Li.Xiubo@freescale.com
List-Id: alsa-devel@alsa-project.org


Hi Nicolin

> > static struct asoc_simple_card_info fsi_wm8978_info = {
> > 	...
> > 	.daifmt		= SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM,
> > 	.cpu_dai = {
> > 		...
> > 		.fmt	= SND_SOC_DAIFMT_IB_NF,
> > 	},
> > 	.codec_dai = {
> > 		...
> > 		.fmt	= SND_SOC_DAIFMT_NB_NF,
> > 	},
> > };
> 
> This would be better imo.
> 
> And ideally we should also keep the xB_xF identical like Mark said _identical_.
> Just some cpu dai drivers might do an incorrect settings for it, like regarding
> NB as sampling on rising edge and IF as active low (I'm saying this without a
> careful check though), which results people need to re-set bitclock-invert and
> frame-invert if they switch the DAI format from left_j to i2s for example.

Wow... I had misunderstood...
I need to send fixup patch after lunch.