From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A32C49ED9 for ; Tue, 10 Sep 2019 23:56:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 741862084C for ; Tue, 10 Sep 2019 23:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ujwKMmOs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 741862084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2FBD116D7; Wed, 11 Sep 2019 01:55:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2FBD116D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568159757; bh=vE5/e9DD0cmW3OhdDT4LteP5tSu+FvUyMzbPLGXKcsY=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ujwKMmOs0+T+y462bcP3AQYRboI47wAvIad7PmtJyLD0p6OvIXqd+AmFiSGSbQZrS 1iY+OAc9k0mF35Ug2wayEB+AD3i1QNd8GzFc/EQwEfw+w3xQKN0m+YWlqwumctCj/+ YIf9W1bkO3zCFu7M6UtDxd1N4KXE3kciGIm+ovZA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B48EEF80321; Wed, 11 Sep 2019 01:55:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AA92BF80368; Wed, 11 Sep 2019 01:55:04 +0200 (CEST) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id B20C1F800A9 for ; Wed, 11 Sep 2019 01:54:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B20C1F800A9 Date: 11 Sep 2019 08:54:54 +0900 X-IronPort-AV: E=Sophos;i="5.64,491,1559487600"; d="scan'208";a="26265115" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 11 Sep 2019 08:54:54 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id ACD124003ECD; Wed, 11 Sep 2019 08:54:54 +0900 (JST) Message-ID: <87ef0n671t.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: "Sridharan, Ranjani" In-Reply-To: References: <8736h4nby1.wl-kuninori.morimoto.gx@renesas.com> <87pnk8lxbu.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA , Mark Brown Subject: Re: [alsa-devel] [PATCH 09/13] ASoC: soc-core: use devm_kzalloc() for rtd X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Sridharan Thank you for your review > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -370,11 +370,8 @@ static void soc_free_pcm_runtime(struct snd_soc_pcm_runtime *rtd) > if (!rtd) > return; > > - kfree(rtd->codec_dais); > - if (rtd->dev) > - device_unregister(rtd->dev); /* soc_release_rtd_dev */ > list_del(&rtd->list); > - kfree(rtd); > > Morimoto-san, > > Just curious, why did you remove the check for if(rtd->dev) here before calling device_unregister()? > > Thanks, > Ranjani > > + device_unregister(rtd->dev); /* soc_release_rtd_dev */ > } Can you check [07/13] patch ? It allocs rtd->dev (as dev) first, and allocs rtd next. This means, if it has rtd, it has rtd->dev. Here, this function checks rtd pointer. If rtd is not NULL, rtd->dev is also not NULL. But, indeed it is a littile bit tricky ? Some comment is needed. Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel