From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80050C33CAF for ; Mon, 20 Jan 2020 00:33:32 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0387920678 for ; Mon, 20 Jan 2020 00:33:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="By7H1ezy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0387920678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 40A3A1666; Mon, 20 Jan 2020 01:32:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 40A3A1666 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579480410; bh=U0wAEnEepOQdv1KSJtNKe1QE2mQFSDxVkOw1k7HKao8=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=By7H1ezy/k+GrFKQ3EgC62iSUUTmgP/2/yAmLKRTwhbm0MJs4ZIiQoOiU6E+YQZtA MdTgVl2uAJEIBZghlQ1sx7lp4LGnAhQpi7WWKw4Dgp2tgDV990qUudCaHH2JVAOVTC rqpqNyl/HkuU6sgQR6QhcVbaOVBWhsjJKRR8f+mA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B82D4F80143; Mon, 20 Jan 2020 01:32:39 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2B450F801D9; Mon, 20 Jan 2020 01:32:35 +0100 (CET) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id 526B6F800E2 for ; Mon, 20 Jan 2020 01:32:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 526B6F800E2 Date: 20 Jan 2020 09:32:23 +0900 X-IronPort-AV: E=Sophos;i="5.70,339,1574089200"; d="scan'208";a="37080033" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 20 Jan 2020 09:32:23 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id D805A40FB3AE; Mon, 20 Jan 2020 09:32:23 +0900 (JST) Message-ID: <87ftgbynl4.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Daniel Baluta In-Reply-To: References: User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: "alsa-devel@alsa-project.org" Subject: Re: [alsa-devel] soc-core: Questions about cpus->name && cpus->of_node X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Daniel > =BB /* > =BB * CPU device may be specified by either name or OF node, but > =BB * can be left unspecified, and will be matched based on DAI > =BB * name alone.. > =BB */ > =BB if (link->cpus->name && link->cpus->of_node) { > =BB =BB dev_err(card->dev, > =BB =BB =BB "ASoC: Neither/both cpu name/of_node are se= t for %s\n", > =BB =BB =BB link->name); > =BB =BB return -EINVAL; > =BB } > = > Here either the warning message is wrong OR the if () condition is wrong. > = > If the link->cpus->name =3D NULL && link->cpus->of_node =3D=3D NULL = > the warning message will be not be printed. = It seems it was added by this patch bc92657a11c0982783979bbb84ceaf58ba222124 ("ASoC: make snd_soc_dai_link more symmetrical") it removes - if (!!link->cpu_dai_name =3D=3D !!link->cpu_dai_of_node) { Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel