From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11106ECE58F for ; Wed, 16 Oct 2019 00:34:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CDC020854 for ; Wed, 16 Oct 2019 00:34:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Mh2Lfmmx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CDC020854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BAA17846; Wed, 16 Oct 2019 02:34:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BAA17846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1571186096; bh=6GFDlulFRi+KcV6DbmaY4Ouh/b94FqgtFRAg2e07dF0=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Mh2LfmmxkpZXa6ej2Wq1tyHB9NeEqCkZzURhwV3x0D/G+0gaCQQHt33Spdjl6SEUX 2RIaNAYPNCbLSI+209bnxwbtZthD41izXT25VR/7cYMCykMxntxKc0ksGbcVkNS1Yd 2NfJf9xNbm9g+sgI3wtLWOuWNpBKmzMmjMx3al7o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3FD02F804A9; Wed, 16 Oct 2019 02:34:06 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F3652F804AA; Wed, 16 Oct 2019 02:34:04 +0200 (CEST) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 310DDF8011D for ; Wed, 16 Oct 2019 02:33:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 310DDF8011D Date: 16 Oct 2019 09:33:56 +0900 X-IronPort-AV: E=Sophos;i="5.67,301,1566831600"; d="scan'208";a="28965663" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 16 Oct 2019 09:33:56 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 49077400965E; Wed, 16 Oct 2019 09:33:56 +0900 (JST) Message-ID: <87mue1wmtn.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Peter Ujfalusi In-Reply-To: References: <20191008115720.7135-1-peter.ujfalusi@ti.com> <87lftm68d6.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com Subject: Re: [alsa-devel] [PATCH] ASoC: pcm3168a: Use fixup instead of constraint for channels and formats X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Peter Thank you for your fixup patch > > This patch breaks my sound. > > I'm selecting I2S between CPU<->Codec, and > > before this patch, it had been selected 24bit + I2S. > > But after this patch, it selects 16bit + I2S, > > and say "16-bit slots are supported only for slave mode using right justified" > > Oops. I have sent a patch to fix this. Sorry for the inconvenience! No problem. Thank you for your quick response. > > I'm not 100% understand pcm3168a. > > I'm happy if you can solve this issue. > > If you can't, can you please teach me where should I check ? > > Just sent a patch to fix the issue you are seeing with I2S mode (tested > it myself). Yes, Thanks. It could solve my issue. Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel