Re: [PATCH 0/8] ALSA: hda: Add model option to codec drivers, too

[Takashi Iwai <tiwai@suse.de>]

On Thu, 29 Sep 2022 09:46:47 +0200,
Jaroslav Kysela wrote:
> 
> On 29. 09. 22 9:35, Takashi Iwai wrote:
> > Hi,
> > 
> > this is a trivial patch set to add the "model" option to each HD-audio
> > codec driver that works equivalently with snd-hda-intel or SOF
> > driver's model option.  It makes it easer for users to specify the
> > quirk to the right target.
> 
> I am not convinced, if it's "easier" for users. Perhaps, it will make
> more sense to add this option to the snd_intel_dspcfg module (so the
> model can be controlled in the one place). I admit that users are a
> bit confused with the snd-hda-intel and SOF differences.

Yes, and that's another reason for moving this rather to codec.
By applying directly the option to the codec driver, it works no
matter which control driver is used.

And, snd_intel_dspcfg is no better choice, IMO.  If you have multiple
controllers, you'll hit the same problem as snd-hda-intel.
(And SOF ignores that use case completely, but it's fine, as SOF is
more or less bound only with the onboard controller.)


Takashi