From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010F1C32771 for ; Thu, 16 Jan 2020 00:48:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F963222C3 for ; Thu, 16 Jan 2020 00:48:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vYUeczNr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F963222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B8CEA17A4; Thu, 16 Jan 2020 01:47:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B8CEA17A4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579135719; bh=kYTVcfnah/YKFzW0YiSIib0CyuRfZVOgkyP4iozZ1Ug=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vYUeczNrJUykaTY7DgSn45Hh3+HS/LMrhlwlMqc+iwp4r4c+e7OZgeRXz2lFDw/3p 62AuC70oEyKU3NzYRplNegKdiw7mLgkURq3cW+wveKHLu61PK8staidBYQV+71kybr ClQIwQ9sGiEAWC2JnVnGPEf6vjvb3g0fhkmqtrX8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4B9DEF8014B; Thu, 16 Jan 2020 01:47:49 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8ECCBF801EB; Thu, 16 Jan 2020 01:47:47 +0100 (CET) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id DFD26F800CC for ; Thu, 16 Jan 2020 01:47:37 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DFD26F800CC Date: 16 Jan 2020 09:47:35 +0900 X-IronPort-AV: E=Sophos;i="5.70,323,1574089200"; d="scan'208";a="36784424" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 16 Jan 2020 09:47:35 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id B4E1B400C9E9; Thu, 16 Jan 2020 09:47:35 +0900 (JST) Message-ID: <87pnfk1b2w.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart In-Reply-To: References: <20200114175152.3291-1-yung-chuan.liao@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: alsa-devel@alsa-project.org, tiwai@suse.de, liam.r.girdwood@linux.intel.com, broonie@kernel.org, Bard liao , bard.liao@intel.com Subject: Re: [alsa-devel] [PATCH RFC v2 0/4] ASoC: Add Multi CPU DAI support X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis > After this series of patches is applied, we have this in soc.h: > > struct snd_soc_dai *codec_dai; > struct snd_soc_dai *cpu_dai; > > struct snd_soc_dai **codec_dais; > unsigned int num_codecs; > > struct snd_soc_dai **cpu_dais; > unsigned int num_cpus; > > What is the intent behind keeping the two fields codec_dai and cpu_dai? > > Shouldn't we use the multi-dai structures in all cases, possible > degraded to a single element rather than maintaining what looks like > duplicate ways of accessing the same element? > > If removing these fields across all drivers is just too invasive for > now, shouldn't we start defining access macros so that those fields > can be deprecated and removed at a later time, platform-by-platform? Actually, I have this patch (= remove cpu_dai/codec_dai from all drivers, and use macro for it), and have plan to post it. But, I have many extra cleanup patches in my tree, and I want to post it before that (to avoid extra re-ordering dpendency break). Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel