Re: [PATCH v2 4/4] ASoC: soc-topology.c: remove unnecessary dai_link->platform

[Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>]

Hi Peter

Thank you for your feedback.

> > @@ -1694,11 +1694,9 @@ static int soc_tplg_fe_link_create(struct soc_tplg *tplg,
> >  
> >  	link->cpus	= &dlc[0];
> >  	link->codecs	= &dlc[1];
> > -	link->platforms	= &dlc[2];
> >  
> >  	link->num_cpus	 = 1;
> >  	link->num_codecs = 1;
> > -	link->num_platforms = 1;
> >  
> >  	link->dobj.index = tplg->index;
> >  	link->dobj.type = SND_SOC_DOBJ_DAI_LINK;
> > @@ -1726,8 +1724,6 @@ static int soc_tplg_fe_link_create(struct soc_tplg *tplg,
> >  	link->codecs->name = "snd-soc-dummy";
> >  	link->codecs->dai_name = "snd-soc-dummy-dai";
> >  
> > -	link->platforms->name = "snd-soc-dummy";
> > -
> 
> I think this patch is incorrect and should be reverted (I have received
> a note from a SOF developer).
> The link->cpus->dai_name is not necessarily "snd-soc-dummy", it is set
> earlier:
> if (strlen(pcm->dai_name)) {
> 	link->cpus->dai_name = devm_kstrdup(tplg->dev, pcm->dai_name,
> 					    GFP_KERNEL);
> 	if (!link->cpus->dai_name) {
> 		ret = -ENOMEM;
> 		goto err;
> 	}
> }
> 
> We cannot be sure that it is the same component, in fact it is most like
> not.

But sorry, I don't understand the point.
This patch removed dummy PLATFORM which is not necessary I think,
but you are talking about CPU.
Could you please explain more detail what is the problem ?


Thank you for your help !!

Best regards
---
Kuninori Morimoto