From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10348C433DB for ; Wed, 24 Feb 2021 23:14:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23FFD64EDD for ; Wed, 24 Feb 2021 23:14:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23FFD64EDD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B5BE14E; Thu, 25 Feb 2021 00:13:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B5BE14E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614208454; bh=cOuVwUsF6cPjieg9RAY0FpUkhyh6Xftnp3qbYEXBzyg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uK8bhyCPIylw1oCDN0EDmQIlS6DV+aRLF59SMOrDJhKjk7qpLuekUYU/e9Z+0MPkG YWYqlMreC0ZqrCbaKs0GkZWXIsJdhAIWvQsQU1gEu2mmc92KXYv9LsMjS0W/LhcHWg JqPpNt2iEdoRJkvM4Byv2G9ux2QTulgVI+Vh3cEc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 474B6F80161; Thu, 25 Feb 2021 00:13:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8B889F8016C; Thu, 25 Feb 2021 00:13:22 +0100 (CET) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 341D8F80159 for ; Thu, 25 Feb 2021 00:13:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 341D8F80159 Date: 25 Feb 2021 08:13:12 +0900 X-IronPort-AV: E=Sophos;i="5.81,203,1610377200"; d="scan'208";a="73054786" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 25 Feb 2021 08:13:12 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id E13E2400F79E; Thu, 25 Feb 2021 08:13:12 +0900 (JST) Message-ID: <87r1l5rref.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart Subject: Re: [PATCH 4/8] ASoC: sh: rcar: core: rename shadowing variables In-Reply-To: <03f560f1-2389-424d-5d4c-84e244baca1c@linux.intel.com> References: <20210219231635.5749-1-pierre-louis.bossart@linux.intel.com> <20210219231635.5749-5-pierre-louis.bossart@linux.intel.com> <87wnv1vw6a.wl-kuninori.morimoto.gx@renesas.com> <03f560f1-2389-424d-5d4c-84e244baca1c@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis > >> sound/soc/sh/rcar/core.c:1369:22: style: Local variable 'rdai' shadows > >> outer variable [shadowVariable] > >> struct rsnd_dai *rdai = rsnd_rdai_get(priv, dai_i); > >> ^ > > > > I'm not 100% sure about this warning, > > but this path is overkill. Maybe below is enough ? > > Hi Morimoto-san, > It might be better if we drop this patch from the series and have you > send the proper fix with my Reported-by tag. > Would that work for you? OK, thanks. Will do today Thank you for your help !! Best regards --- Kuninori Morimoto