From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A2E6C33CAF for ; Fri, 17 Jan 2020 00:46:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C98F820748 for ; Fri, 17 Jan 2020 00:46:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="drMUDKTQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C98F820748 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9CB0517D2; Fri, 17 Jan 2020 01:45:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9CB0517D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579221972; bh=Bnuyf7VW5NGcihkv4hFo0PZkMTLOUtyeetsOrqiHHks=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=drMUDKTQR4h8X4ukzv+UONRYAmkY9TX7MM8sLYJIgEH0VgqsAZGOf3CBAHtdzag0C IboNpnDCyjcI3XwSJVrfu7WKwBSM995Uf/onby4i28DrkpRNc0QstZSOpJfVtwU4Dh zz4wrUszdqAd6qADgA5S7TLFpXdUKPagmRoaS4hg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0ED1FF8014D; Fri, 17 Jan 2020 01:45:22 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 452E0F8014E; Fri, 17 Jan 2020 01:45:19 +0100 (CET) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id B8598F800B9 for ; Fri, 17 Jan 2020 01:45:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B8598F800B9 Date: 17 Jan 2020 09:45:09 +0900 X-IronPort-AV: E=Sophos;i="5.70,327,1574089200"; d="scan'208";a="36884732" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 17 Jan 2020 09:45:09 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 7DCAC400F924; Fri, 17 Jan 2020 09:45:09 +0900 (JST) Message-ID: <87sgkerjvu.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: "Liao, Bard" In-Reply-To: <0dbffd0c1b904a1eb57045ff3b5e40b2@intel.com> References: <20200114175152.3291-1-yung-chuan.liao@linux.intel.com> <20200114175152.3291-5-yung-chuan.liao@linux.intel.com> <35fbbfcf-8741-ac4c-56b1-2fd7e19e1a7d@linux.intel.com> <0dbffd0c1b904a1eb57045ff3b5e40b2@intel.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: "alsa-devel@alsa-project.org" , "tiwai@suse.de" , Pierre-Louis Bossart , "liam.r.girdwood@linux.intel.com" , "broonie@kernel.org" , Bard liao Subject: Re: [alsa-devel] [PATCH RFC v2 4/4] ASoC: add warning if the function is not support multi cpu yet. X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Liao > > > 223cd045719e..bf9d6a21bcd9 100644 > > > --- a/sound/soc/soc-compress.c > > > +++ b/sound/soc/soc-compress.c > > > @@ -810,10 +810,11 @@ int snd_soc_new_compress(struct > > snd_soc_pcm_runtime *rtd, int num) > > > int playback = 0, capture = 0; > > > int i; > > > > > > - if (rtd->num_codecs > 1) { > > > + if (rtd->num_cpus > 1 || > > > + rtd->num_codecs) { > > > dev_err(rtd->card->dev, > > > - "Compress ASoC: Multicodec not supported\n"); > > > - return -EINVAL; > > > + "Compress ASoC: Multi CPU/Codec not supported\n"); > > > + return -ENOTSUPP; > > > > so this is an error... > > Changing to -ENOTSUPP will prevent below to return error in > soc_init_pcm_runtime(). > > /* create compress_device if possible */ > ret = snd_soc_dai_compress_new(cpu_dai, rtd, num); > if (ret != -ENOTSUPP) { > if (ret < 0) > dev_err(card->dev, "ASoC: can't create compress %s\n", > dai_link->stream_name); > return ret; > } > > So it is to prevent an error actually. But I agree it is better to return > an error when we have an unexpected number of cpu dais. What do you > think? @Morimoto-san Yes, it should return error (= should not prevent error) I think Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel