From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C68C433DB for ; Sun, 7 Mar 2021 22:38:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF04765155 for ; Sun, 7 Mar 2021 22:38:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF04765155 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 91D8018EE; Sun, 7 Mar 2021 23:37:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 91D8018EE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1615156714; bh=QK4AnFs9460YIShv/8ZMRzUscKhe5ERASd8TnbIf8JE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TDI0W691P8hZ8hps0UXLm34vH5vIxM2bMSuuDmNI6w7iH1pS+kBRZwEEqBPoEVwc+ XNW8KWDGOi0x3o/e0RBXZAO3eDhjUd9322+SqjYc35HVQID73BIYItFmobVS3i5FYe cIM4ZGiSO/QKK9kmWuRHHzSv88RQsBR164K1nxkM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1CABCF800ED; Sun, 7 Mar 2021 23:37:44 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0CC6AF80227; Sun, 7 Mar 2021 23:37:42 +0100 (CET) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 8F4FEF80139 for ; Sun, 7 Mar 2021 23:37:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8F4FEF80139 Date: 08 Mar 2021 07:37:28 +0900 X-IronPort-AV: E=Sophos;i="5.81,231,1610377200"; d="scan'208";a="74118435" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 08 Mar 2021 07:37:28 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 2F7A441088F8; Mon, 8 Mar 2021 07:37:28 +0900 (JST) Message-ID: <87tupmvbdj.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart Subject: Re: [PATCH 6/8] ASoC: soc-pcm: fixup dpcm_be_dai_startup() user count In-Reply-To: <94eb9f41-3d1d-8054-2f12-16fba9dddaea@linux.intel.com> References: <87tupqpg9x.wl-kuninori.morimoto.gx@renesas.com> <87lfb2pg8a.wl-kuninori.morimoto.gx@renesas.com> <94eb9f41-3d1d-8054-2f12-16fba9dddaea@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Linux-ALSA , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis, Mark Thank you for your review. > > From: Kuninori Morimoto > > > > At dpcm_be_dai_startup_unwind(), it indicates error message at (1) > > if this function was called with no users. > > But, it doesn't use "continue" here. Thus, it will be minus > > users at (2). > > suggested edit: > > "Thus, users will be a negative number at (2)" Ah it is better :) Mark, can I repost it ? I'm happy if you tidyup it if you are OK for appling. Thank you for your help !! Best regards --- Kuninori Morimoto