From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F715C2D0C7 for ; Thu, 12 Dec 2019 02:42:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB9C720836 for ; Thu, 12 Dec 2019 02:42:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="sk1PiPOb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB9C720836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1E47A851; Thu, 12 Dec 2019 03:41:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1E47A851 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1576118535; bh=+NpyIhblzAp0wSVx1I4Jj+7s/fCyGFz/S8yYljRJPk8=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sk1PiPObn9ygLOYmN7WlsN0Lb2N1vW7KogUFaLeJWTMbyaLSg0Zh7+Y86E8r12KD7 ip/aHDHfMGoOrlpMzxbsH6rUxGJGIKA45Pbamc2jAwC23vnx7qQmSX0FjmHSaK4Koj 6At64RVP7M93VfknOW8l02b/wf7tCJ7QNgMRuY9o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9A12DF801D8; Thu, 12 Dec 2019 03:41:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8F282F8020C; Thu, 12 Dec 2019 03:41:23 +0100 (CET) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 98416F80139 for ; Thu, 12 Dec 2019 03:41:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 98416F80139 Date: 12 Dec 2019 11:41:15 +0900 X-IronPort-AV: E=Sophos;i="5.69,304,1571670000"; d="scan'208";a="33957819" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 12 Dec 2019 11:41:15 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 738B640078A5; Thu, 12 Dec 2019 11:41:15 +0900 (JST) Message-ID: <87tv66clkk.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart In-Reply-To: References: <87pngue4ia.wl-kuninori.morimoto.gx@renesas.com> <87o8wee4hf.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA , Mark Brown Subject: Re: [alsa-devel] [PATCH 01/15] ASoC: soc-core: support snd_soc_dai_link_component for codec_conf X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis Thank you for your feedback > > From: Kuninori Morimoto > > > > To find codec_conf component, it is using dev_name, of_node. > > But, we already has this kind of finding component method by > > snd_soc_dai_link_component, and snd_soc_is_matching_component(). > > We shouldn't have duplicate implementation to do same things. > > This patch adds snd_soc_dai_link_component support to find > > codec_conf component. > > > > Signed-off-by: Kuninori Morimoto > > Thanks Morimoto-san, this looks good to me, but I couldn't resist a > small nit-pick below. > > > --- > > include/sound/soc.h | 3 +++ > > sound/soc/soc-core.c | 18 +++++++++++------- > > 2 files changed, 14 insertions(+), 7 deletions(-) > > > > diff --git a/include/sound/soc.h b/include/sound/soc.h > > index 82e6523..dab1212 100644 > > --- a/include/sound/soc.h > > +++ b/include/sound/soc.h > > @@ -949,6 +949,7 @@ struct snd_soc_dai_link { > > #define COMP_CODEC(_name, _dai) { .name = _name, .dai_name = _dai, } > > #define COMP_PLATFORM(_name) { .name = _name } > > #define COMP_AUX(_name) { .name = _name } > > +#define COMP_CODEC_CNF(_name) { .name = _name } > > COMP_CODEC_CONF() ? > > CNF is not an acronym/concept we use anywhere else, whereas codec_conf > is pretty much the default for variable naming. I see. I will fixup and post v2 tomorrow. Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel