From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B06C433E0 for ; Sun, 21 Feb 2021 23:28:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 273A464D8F for ; Sun, 21 Feb 2021 23:28:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 273A464D8F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C6862165E; Mon, 22 Feb 2021 00:27:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C6862165E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1613950106; bh=PRqNO2BSUT+wRKeKcP85F0Np4jggClT8IrH1ZFITetw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QhdtU4DrWumuGbgMasFJquDPw26c2e6MSAGkb9ph5Tnu9bS90KJ9CCLgD8rCPpJ8k ddkBZaoGb0/U/VFEIfKhJamSExPDTSbs/CUOqF/UZRmjyGtTHl2faO+ZiBq5eTMNWU YhOcPIFQOc2sfvvxugOz6CPJ+y+9n7giUefRwzQE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4CF93F80167; Mon, 22 Feb 2021 00:27:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1A85BF8016A; Mon, 22 Feb 2021 00:27:35 +0100 (CET) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 05B84F800F3 for ; Mon, 22 Feb 2021 00:27:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 05B84F800F3 Date: 22 Feb 2021 08:27:25 +0900 X-IronPort-AV: E=Sophos;i="5.81,195,1610377200"; d="scan'208";a="72718777" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 22 Feb 2021 08:27:25 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 7F0144009660; Mon, 22 Feb 2021 08:27:25 +0900 (JST) Message-ID: <87wnv1vw6a.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart Subject: Re: [PATCH 4/8] ASoC: sh: rcar: core: rename shadowing variables In-Reply-To: <20210219231635.5749-5-pierre-louis.bossart@linux.intel.com> References: <20210219231635.5749-1-pierre-louis.bossart@linux.intel.com> <20210219231635.5749-5-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis > sound/soc/sh/rcar/core.c:1369:22: style: Local variable 'rdai' shadows > outer variable [shadowVariable] > struct rsnd_dai *rdai = rsnd_rdai_get(priv, dai_i); > ^ I'm not 100% sure about this warning, but this path is overkill. Maybe below is enough ? --------- diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 8533aa696183..cae9639c0ef9 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -1382,7 +1382,7 @@ static int rsnd_dai_probe(struct rsnd_priv *priv) for_each_endpoint_of_node(dai_node, dai_np) { __rsnd_dai_probe(priv, dai_np, dai_i); if (rsnd_is_gen3(priv)) { - struct rsnd_dai *rdai = rsnd_rdai_get(priv, dai_i); + rdai = rsnd_rdai_get(priv, dai_i); rsnd_parse_connect_graph(priv, &rdai->playback, dai_np); rsnd_parse_connect_graph(priv, &rdai->capture, dai_np); @@ -1393,7 +1393,7 @@ static int rsnd_dai_probe(struct rsnd_priv *priv) for_each_child_of_node(dai_node, dai_np) { __rsnd_dai_probe(priv, dai_np, dai_i); if (rsnd_is_gen3(priv)) { - struct rsnd_dai *rdai = rsnd_rdai_get(priv, dai_i); + rdai = rsnd_rdai_get(priv, dai_i); rsnd_parse_connect_simple(priv, &rdai->playback, dai_np); rsnd_parse_connect_simple(priv, &rdai->capture, dai_np); ---- Thank you for your help !! Best regards --- Kuninori Morimoto