From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.intel.com,
ranjani.sridharan@linux.intel.com, broonie@kernel.org,
daniel.baluta@nxp.com
Subject: Re: [PATCH] ASoC: soc-pcm: fix hw param limits calculation for multi-DAI
Date: 18 Feb 2021 08:17:10 +0900 [thread overview]
Message-ID: <87y2fmwaut.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20210216164348.3018179-1-kai.vehmanen@linux.intel.com>
Hi Kai
> In case DPCM runtime has multiple CPU DAIs, dpcm_init_runtime_hw()
> is called multiple times, once for each CPU DAI. This will
> will lead to ignoring hw limits of all but the first DAI.
>
> Fix this by moving soc_pcm_hw_init() up by one level to
> dpcm_init_runtime_hw().
>
> Fixes: 140f553d1298 ("ASoC: soc-pcm: fix hwparams min/max init for dpcm")
> Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> ---
Sorry I couldn't post patch because I had Holiday yesterday.
Thank you for this patch !
I'm happy it could solve your issue.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
prev parent reply other threads:[~2021-02-17 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 16:43 [PATCH] ASoC: soc-pcm: fix hw param limits calculation for multi-DAI Kai Vehmanen
2021-02-17 23:17 ` Kuninori Morimoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2fmwaut.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).