alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 6/8] ASoC: sof: use snd_compress_ops
Date: 20 Apr 2020 15:56:16 +0900	[thread overview]
Message-ID: <87zhb6ve5r.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <9401d09f060ea3143c4304fd2944dafe738f1643.camel@linux.intel.com>


Hi Ranjani

Thank you for your review

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > We can use snd_compress_ops.
> > Let's switch to use it.
> > 
> > Upstream code doesn't have sof_compressed_ops.
> > This patch assume it is implemented at out-of-tree.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
(snip)
> > -int sof_probe_compr_open(struct snd_compr_stream *cstream,
> > -		struct snd_soc_dai *dai)
> > +int sof_probe_compr_open(struct snd_soc_component *component,
> > +			 struct snd_compr_stream *cstream,
> > +			 struct snd_soc_dai *dai)
> 
> But this one seems incorrect? This op (and the ones below except for
> copy) is actually the startup op in struct snd_soc_cdai_ops.

Ohh, yes, indeed.
My compile test didn't have CONFIG_SND_SOC_SOF_HDA somehow.
Thank you for pointing it. I will fixit in v2

Thank you for your help !!

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2020-04-20  6:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17  5:05 [PATCH 0/8] ASoC: add snd_compress_ops and replace Kuninori Morimoto
2020-04-17  5:06 ` [PATCH 1/8] ASoC: soc-compress: add snd_compress_ops Kuninori Morimoto
2020-04-17  5:06 ` [PATCH 2/8] ASoC: codec: wm_adsp: use snd_compress_ops Kuninori Morimoto
2020-04-17  5:06 ` [PATCH 3/8] ASoC: uniphier: " Kuninori Morimoto
2020-04-17  5:06 ` [PATCH 4/8] ASoC: qcom: q6sp6: " Kuninori Morimoto
2020-04-17  5:06 ` [PATCH 5/8] ASoC: intel: atom: " Kuninori Morimoto
2020-04-17  5:06 ` [PATCH 6/8] ASoC: sof: " Kuninori Morimoto
2020-04-17  5:39   ` Ranjani Sridharan
2020-04-20  6:56     ` Kuninori Morimoto [this message]
2020-04-17  5:07 ` [PATCH 7/8] ASoC: sprd: " Kuninori Morimoto
2020-04-17  5:07 ` [PATCH 8/8] ASoC: soc-compress: remove snd_compr_ops Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhb6ve5r.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ranjani.sridharan@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).