From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43AEDC352AA for ; Wed, 2 Oct 2019 08:00:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 428432070B for ; Wed, 2 Oct 2019 08:00:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="tuAJFj6+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 428432070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1C2B81666; Wed, 2 Oct 2019 09:59:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1C2B81666 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1570003210; bh=6M1NNuFLhCz/uMXcsuqJ3u0cP7ifKOCcMQ3kIcsPcRE=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tuAJFj6+WKXYp8CxzjpNV+OCzU9v6aGxz+JlNRc2JSw8wkp3BA1e8zYlNlOzxrzao 29SHqBAHkZ3ThkuHV/RjB5Fit55fIKx5I135LsfmNdc+/eGFuTEejkvuyrFwNgEuDH yGRn5oO1aBSlA2+Lc47ir/19yupeH2ddrxG1aoz0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A9F30F80377; Wed, 2 Oct 2019 09:59:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CEA62F80391; Wed, 2 Oct 2019 09:59:18 +0200 (CEST) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 1D60FF8016F for ; Wed, 2 Oct 2019 09:59:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1D60FF8016F Date: 02 Oct 2019 16:59:10 +0900 X-IronPort-AV: E=Sophos;i="5.64,573,1559487600"; d="scan'208";a="27872642" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 02 Oct 2019 16:59:10 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id B9C194006DF1; Wed, 2 Oct 2019 16:59:10 +0900 (JST) Message-ID: <87zhij7f3l.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Daniel Baluta In-Reply-To: References: <878sq3bu2t.wl-kuninori.morimoto.gx@renesas.com> <87zhijafgk.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Cc: Linux-ALSA , Mark Brown Subject: Re: [alsa-devel] [PATCH 5/6] ASoC: soc-core: setup card->rtd_num at snd_soc_instantiate_card() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Daniel Thank you for your feedback > > @@ -2008,6 +2006,7 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card) > > goto probe_end; > > > > /* add predefined DAI links to the list */ > > + card->num_rtd = 0; > > Shouldn't this be placed before the comment above? > > > for_each_card_prelinks(card, i, dai_link) { > > ret = snd_soc_add_dai_link(card, dai_link); > > if (ret < 0) It is used under this for_each_card_prelinks() loop. card->num_rtd setup and this loop are 1 set. Thus, I added it under comment. Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel