From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3919C71143 for ; Fri, 18 Aug 2023 12:53:59 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3F2BFE74; Fri, 18 Aug 2023 14:53:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3F2BFE74 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692363237; bh=7YqFcWNg2Fv2nlDyEHSlWqWCIq2Qdgqd6/JGbDJA9Vw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=pU7AgbHPKu0NFGO+s2tksEKDeBSvN6sjqyoEyyQQ9y0kvhZ7rOZzCNux2nCp47QQR MLYDFz1piGwnptLdRm+y6j4IMK9bOFH1MgWtOwAYBqOKc6e84waCD1efRSUUzHKit+ JA6KAjt4jzyb0aBJteP9Nf8YJ/fDmArq8er/OWjw= Received: by alsa1.perex.cz (Postfix, from userid 50401) id CFB7EF80290; Fri, 18 Aug 2023 14:52:46 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 47552F800D1; Fri, 18 Aug 2023 14:52:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B25F9F801EB; Fri, 18 Aug 2023 14:52:42 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0B60DF800D1 for ; Fri, 18 Aug 2023 14:52:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0B60DF800D1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=MXMcnrYz Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9644F618B6; Fri, 18 Aug 2023 12:52:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E8CCC433C8; Fri, 18 Aug 2023 12:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692363155; bh=7YqFcWNg2Fv2nlDyEHSlWqWCIq2Qdgqd6/JGbDJA9Vw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MXMcnrYzP2vHwKmZfTTGN057SXLQsJMx7wODXLJ0rveDFZN/vQFOL8N27p16BjzIe NDQyO/MiZ043Umd71q3NTHS5Iy/p1xvel5R/+zRToohjhPE6mplNSw4zICCCzRO5Tx eymUvIzwDz1/U7r/qXUXTq7ywNhfABmzUPQMjTC+JBBTzpefC34wrLoYeSSWzQYPKE OHv/b7R/M2xaj5MgqFZcW/T44aOHUjNKDoYV/AvyoUIbJ3FQq8ZuJA+HL2KgJjA0wH 45m7g9rsYyUHYRB6NziZga9ENrghnZdMnBuNarTrElxxcvLtDFLRNrmD3j96OlIykP er7I8XeJaAPpw== Date: Fri, 18 Aug 2023 13:52:29 +0100 From: Mark Brown To: Marian Postevca Cc: =?utf-8?B?5rKI5LiA6LaF?= , yangxiaohua , Zhu Ning , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec Message-ID: <8cddbe1c-20d7-4b8f-ba02-f86bbb5a54c5@sirena.org.uk> References: <141a3320-ff65-459f-9d00-c8bed691dcfc@sirena.org.uk> <87lejpwxzf.fsf@mutex.one> <87ttycjyw3.fsf@mutex.one> <87r0t9uc08.fsf@mutex.one> <87zg2pxtog.fsf@mutex.one> <87o7j5b9bd.fsf@mutex.one> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Z+806srFnaL0BPyl" Content-Disposition: inline In-Reply-To: <87o7j5b9bd.fsf@mutex.one> X-Cookie: Your aim is high and to the right. Message-ID-Hash: GBQPBLYHI7XV3ORXPYTKYUUTCBSNDO6Z X-Message-ID-Hash: GBQPBLYHI7XV3ORXPYTKYUUTCBSNDO6Z X-MailFrom: broonie@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Z+806srFnaL0BPyl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 18, 2023 at 01:20:06AM +0300, Marian Postevca wrote: > Mark Brown writes: > > This is saying that the machine driver should disable jack detection > > over suspend and restart it during resume. The machine driver should > > suspend before the rest of the card which should mean that the CODEC > > gets powered off then. The core can't tell if jack detection is > > supposed to work over suspend, it is a standard wake event on systems > > like phones, but it sounds like on this system the power gets removed > > from the device so that can't work. > Sorry, I don't understand what you are trying to say here. My intention > is to find a way to have sound working when suspending/resuming > with jack inserted by not fudging the jack in the machine driver but > fixing it in the CODEC. You'd need to pull the relevant supplies out of DAPM and handle them in the CODEC suspend/resume callback. > > I don't understand why that would be expected to help? The main effect > > of keeping the bias on all the time would be to consume more power. > I don't fully understand the whole bias thing (I did try hard to > understand it from the code), but in this specific instance it helps for > suspending the CODEC. If idle_bias_on is true then idle_bias_off will be Very old devices required keeping a reference voltage maintained at half the analog supply voltage, this supply is called the bias. It couldn't be powered on/off quickly so needed to be kept on all the time. I can't tell which driver you're using here so I can't tell if it's maintaining any system level power like that. --Z+806srFnaL0BPyl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTfaYwACgkQJNaLcl1U h9B/DQf/WTaBHBmfKP02yjMkT4VeN9hLq+f9r25ur3Z5EvIKGj0IYpOL5QASU6pw tmCkN81RBknpWyYWUyDe3TGcKitz5hREeGdfu/NrNwDwS7Z++zCpGZko6De+t49S sEqvf51OT2Uh8sU0lp/MPkF1cQFnNY9gF1ofRwKRlqXlBih+kmCRZl6rOxXFQ6FK nwal2kpnkyoX9uoyMF7LqwJZVNXf6DH1fZZBkTHBbYPcbqRUqtjf2tKjlF56wybU /LmzqyKobRoQ/c6xL3E0iEh98FPnXKsmbxQ8IKOzsvgsq0kGm3GIFQchCMwUEErl +Q3r8dVJ1KIQkvl1dQbeo62LbcwRbw== =atF3 -----END PGP SIGNATURE----- --Z+806srFnaL0BPyl--