From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: vishnu <vravulap@amd.com>,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
open list <linux-kernel@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
djkurtz@google.com, Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Alexander.Deucher@amd.com, Akshu.Agrawal@amd.com
Subject: Re: [alsa-devel] [PATCH v8 2/6] ASoC: amd: Refactoring of DAI from DMA driver
Date: Wed, 20 Nov 2019 08:48:57 -0600 [thread overview]
Message-ID: <9005946f-69b6-1cc6-5a1a-b894d826b960@linux.intel.com> (raw)
In-Reply-To: <991a1c7a-6f34-caab-132d-5687b1f1bfa0@amd.com>
>>> + pm_runtime_set_autosuspend_delay(&pdev->dev, 5000);
>>> + pm_runtime_use_autosuspend(&pdev->dev);
>>> + pm_runtime_enable(&pdev->dev);
>>
>> question: here you want to use pm_runtime for this platform device...
>>
>>> + return 0;
>>> +}
>>> +
>>> +static int acp3x_dai_remove(struct platform_device *pdev)
>>> +{
>>> + pm_runtime_disable(&pdev->dev);
>>> + return 0;
>>> +}
>>> +static struct platform_driver acp3x_dai_driver = {
>>> + .probe = acp3x_dai_probe,
>>> + .remove = acp3x_dai_remove,
>>> + .driver = {
>>> + .name = "acp3x_i2s_playcap",
>>
>> ... but here there is no .pm structure and I don't see any
>> suspend/resume routines for this driver...
>>
>>> + },
>>> +};
>>
>>> @@ -774,13 +586,14 @@ static struct platform_driver acp3x_dma_driver = {
>>> .probe = acp3x_audio_probe,
>>> .remove = acp3x_audio_remove,
>>> .driver = {
>>> - .name = "acp3x_rv_i2s",
>>> + .name = "acp3x_rv_i2s_dma",
>>> .pm = &acp3x_pm_ops,
>>> },
>>
>> ... but for this other platform_driver you do have a .pm structure and
>> suspend-resume implementations.
>>
>> Wondering if this is a miss or a feature?
>>
>
> As per our design, ACP IP specific changes like ACP power on/off will be
> handled in ACP pci driver(parent device for DMA device and I2S
> controller(nothing but CPU DAI))
>
> Where as In DMA driver during runtime suspend/resume interrupts will be
> disabled and enabled.
>
> But in DAI driver there is nothing to be done in suspend and resume just
> returning zero so we have not added PM suspend/resume here in DAI.
>
> So is it expected to add the suspend resumes with returning zero.Or if
> pm runtime is not needed in CPU DAI shall we remove the existing PM
> related calls in DAI.
>
> Please suggest us.
I am far from a pm_runtime expert but I'd remove the calls to
+ pm_runtime_set_autosuspend_delay(&pdev->dev, 5000);
+ pm_runtime_use_autosuspend(&pdev->dev);
+ pm_runtime_enable(&pdev->dev);
if you platform device does not provide any suspend/resume functions and
the parent takes care of everything?
IIRC the status for the platform device would be 'unsupported' but that
shouldn't prevent the parent from suspending/resuming.
A second opinion would be desirable here...
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-20 16:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1574155967-1315-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
2019-11-19 9:32 ` [alsa-devel] [PATCH v8 1/6] ASoC: amd:Create multiple I2S platform device endpoint Ravulapati Vishnu vardhan rao
2019-11-19 11:14 ` Dan Carpenter
2019-11-19 9:32 ` [alsa-devel] [PATCH v8 2/6] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao
2019-11-19 13:53 ` Pierre-Louis Bossart
2019-11-20 7:21 ` vishnu
2019-11-20 14:48 ` Pierre-Louis Bossart [this message]
2019-11-19 9:32 ` [alsa-devel] [PATCH v8 3/6] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao
2019-11-19 9:32 ` [alsa-devel] [PATCH v8 4/6] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao
2019-11-19 9:32 ` [alsa-devel] [PATCH v8 5/6] ASoC: amd: Handle ACP3x I2S-SP Interrupts Ravulapati Vishnu vardhan rao
2019-11-19 9:32 ` [alsa-devel] [PATCH v8 6/6] ASoC: amd: Added ACP3x system resume and runtime pm Ravulapati Vishnu vardhan rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9005946f-69b6-1cc6-5a1a-b894d826b960@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Akshu.Agrawal@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=djkurtz@google.com \
--cc=gustavo@embeddedor.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=vravulap@amd.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).