From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Cc: russianneuromancer@ya.ru, alsa-devel@alsa-project.org,
stable@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk
Date: Mon, 6 Jan 2020 08:23:52 -0600 [thread overview]
Message-ID: <920b8e1a-e01c-08b4-500a-9983a21fccab@linux.intel.com> (raw)
In-Reply-To: <20200106113903.279394-1-hdegoede@redhat.com>
On 1/6/20 5:39 AM, Hans de Goede wrote:
> When a quirk for the Irbis NB41 netbook was added, to override the defaults
> for this device, I forgot to add/keep the BYT_CHT_ES8316_SSP0 part of the
> defaults, completely breaking audio on this netbook.
>
> This commit adds the BYT_CHT_ES8316_SSP0 flag to the Irbis NB41 netbook
> quirk, making audio work again.
>
> Cc: stable@vger.kernel.org
> Cc: russianneuromancer@ya.ru
> Fixes: aa2ba991c420 ("ASoC: Intel: bytcht_es8316: Add quirk for Irbis NB41 netbook")
> Reported-and-tested-by: russianneuromancer@ya.ru
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/boards/bytcht_es8316.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
> index 46612331f5ea..54e97455d7f6 100644
> --- a/sound/soc/intel/boards/bytcht_es8316.c
> +++ b/sound/soc/intel/boards/bytcht_es8316.c
> @@ -442,7 +442,8 @@ static const struct dmi_system_id byt_cht_es8316_quirk_table[] = {
> DMI_MATCH(DMI_SYS_VENDOR, "IRBIS"),
> DMI_MATCH(DMI_PRODUCT_NAME, "NB41"),
> },
> - .driver_data = (void *)(BYT_CHT_ES8316_INTMIC_IN2_MAP
> + .driver_data = (void *)(BYT_CHT_ES8316_SSP0
> + | BYT_CHT_ES8316_INTMIC_IN2_MAP
> | BYT_CHT_ES8316_JD_INVERTED),
> },
> { /* Teclast X98 Plus II */
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-06 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 11:39 [alsa-devel] [PATCH] ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk Hans de Goede
2020-01-06 14:23 ` Pierre-Louis Bossart [this message]
2020-01-06 20:50 ` [alsa-devel] Applied "ASoC: Intel: bytcht_es8316: Fix Irbis NB41 netbook quirk" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=920b8e1a-e01c-08b4-500a-9983a21fccab@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=russianneuromancer@ya.ru \
--cc=stable@vger.kernel.org \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).