From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A7CCA9EAE for ; Tue, 29 Oct 2019 10:45:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE00C2087E for ; Tue, 29 Oct 2019 10:45:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="r/umtm+O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE00C2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EF551220F; Tue, 29 Oct 2019 11:44:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EF551220F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572345947; bh=zLB1ENpa1scq8gYYxfd5NrdSsE1RX43bov/nxL4fS/c=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r/umtm+O2WS6s8/M3lmUc+2mrhQ/CIXdbmyPitYcL/HnQgKidk/m2Fx3reE0dkndx Ww8Z9kRJrWTF2aM+6mz65tSbo2owODNJLOfR2gnm+G2UgivnFVp9NXH8xnDZGU76z6 sbTdqHI7Kpr9b/Z92xtxa5f8c3PpRDGtPFGAzLg4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 73129F800E7; Tue, 29 Oct 2019 11:44:56 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E4D1AF8036C; Tue, 29 Oct 2019 11:44:54 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B6B8FF800E7 for ; Tue, 29 Oct 2019 11:44:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B6B8FF800E7 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2019 03:44:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,243,1569308400"; d="scan'208";a="205434337" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.252.8.198]) ([10.252.8.198]) by FMSMGA003.fm.intel.com with ESMTP; 29 Oct 2019 03:44:46 -0700 To: Pierre-Louis Bossart References: <20191025224122.7718-1-pierre-louis.bossart@linux.intel.com> <20191025224122.7718-18-pierre-louis.bossart@linux.intel.com> From: Cezary Rojewski Message-ID: <977a6bf8-6eac-1aea-426c-10fc41ef4afd@intel.com> Date: Tue, 29 Oct 2019 11:44:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191025224122.7718-18-pierre-louis.bossart@linux.intel.com> Content-Language: en-US Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org, Keyon Jie Subject: Re: [alsa-devel] [PATCH 17/26] ASoC: SOF: PM: add helpers for setting D0 substate for ADSP X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2019-10-26 00:41, Pierre-Louis Bossart wrote: > +int snd_sof_set_d0_substate(struct snd_sof_dev *sdev, > + enum sof_d0_substate d0_substate) > +{ > + int ret; > + > + /* do platform specific set_state */ > + ret = snd_sof_dsp_set_power_state(sdev, d0_substate); > + if (ret < 0) > + return ret; > + > + /* update dsp D0 sub-state */ > + sdev->d0_substate = d0_substate; > + > + return 0; > +} > +EXPORT_SYMBOL(snd_sof_set_d0_substate); Are reason for not merging this directly with snd_sof_dsp_set_power_state? _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel