From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E832C433DB for ; Wed, 24 Feb 2021 12:10:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93829601FE for ; Wed, 24 Feb 2021 12:10:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93829601FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=perex.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1FFD4166A; Wed, 24 Feb 2021 13:09:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1FFD4166A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614168604; bh=u0B8epsNz+KFfv6uIkBdyEY9TspTfXGRPrjDsf6nAZw=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WnfKFxltCBKIGiOCiR7olgMxxa3we9mfGreR4uXht9/y5x8BCL1VGs0+M+bNdhbmZ fMEoe+tdRg2GAJjErG5K9Be4YRAGO49h4tQjAYnLZXvGDJ43l1AxGgS7Dxplrc9pQU XT7334sJkTEPqfk1JRAXik1DB6dbaFAk8MlmM7W8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 80EE9F800F2; Wed, 24 Feb 2021 13:09:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 84F9BF8016C; Wed, 24 Feb 2021 13:09:11 +0100 (CET) Received: from mail1.perex.cz (mail1.perex.cz [77.48.224.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5E55FF800F2 for ; Wed, 24 Feb 2021 13:09:03 +0100 (CET) Received: from mail1.perex.cz (localhost [127.0.0.1]) by smtp1.perex.cz (Perex's E-mail Delivery System) with ESMTP id 32858A0040; Wed, 24 Feb 2021 13:09:03 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.perex.cz 32858A0040 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perex.cz; s=default; t=1614168543; bh=pTNIyAgDWobJPoCbnwxIvRRy/LtmqBtOxDDtSvPAW6k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=cObM/d2TrAFuTytMloCnuqEWFv5KDq/H8GfeSjJTEjVL+G7RxjLrdASkWsJoh+KhS ZfLO61m9iNM/ydy5pAd7apmU3Jld/mBGe1iVEAbQaBVNFRherwbzHbAnuytjr8P4Hk 4Ax5HQXdZpZ8IfBai+fadIFZ5Z/flxtGaNW5paLc= Received: from p1gen2.localdomain (unknown [192.168.100.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: perex) by mail1.perex.cz (Perex's E-mail Delivery System) with ESMTPSA; Wed, 24 Feb 2021 13:08:56 +0100 (CET) Subject: Re: [RFC 2/2] ASoC: rt5670: Add LED trigger support To: Takashi Iwai References: <20210215142419.308651-1-hdegoede@redhat.com> <20210215142419.308651-3-hdegoede@redhat.com> <20210223134506.GF5116@sirena.org.uk> <578b1ee3-f426-c5b5-bc78-5a91108ebdc8@redhat.com> <20210223140930.GH5116@sirena.org.uk> <5c6a21c1-7107-3351-25be-c007b0b946d3@perex.cz> <776b4ad9-2612-b08a-cb76-c3e1ce02388a@perex.cz> <4574088a-4676-131a-0065-499a516f80ae@perex.cz> <03068e15-2157-3ae6-ffd6-7ec315bb49a3@perex.cz> From: Jaroslav Kysela Message-ID: <9c74e8de-769c-cd98-3944-85bd75bc840b@perex.cz> Date: Wed, 24 Feb 2021 13:08:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Oder Chiou , alsa-devel@alsa-project.org, Liam Girdwood , Hans de Goede , Mark Brown , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Dne 24. 02. 21 v 12:43 Takashi Iwai napsal(a): >>> So far, a user control is merely storing the value, let read/write via >>> the control API. That's all, and nothing wrong can happen just by >>> that. Now if it interacts with other subsystem... >>> >>> A more serious concern is rather the fragility of the setup; for >>> enabling the mute LED control, you'd have to create a new user-space >>> control, the function of the control has to be ignored by some >>> application and some not, etc. This has to be done on each machine >> >> You're using "ignore", but as I explained before, the user space switch will >> be used in the whole chain: >> >> capture stream -> >> alsa-lib mute switch / silence PCM stream -> >> PA mute switch / silence PCM stream >> >> So PA can use this switch like the traditional hardware mute switch. > > Does it mean PA would work as of now without any change? Or does it > need patching? Yes, no PA modifications are required with my mechanism. The PA will just see the new user space control - mute switch - created in alsa-lib - which will be synced the internal PA path mute state like for the hardware mute switch. I also think that handling LEDs independently (outside the upper layers like PA) is more flexible. Jaroslav -- Jaroslav Kysela Linux Sound Maintainer; ALSA Project; Red Hat, Inc.