From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A5EC10F25 for ; Fri, 6 Mar 2020 19:59:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D79FD20709 for ; Fri, 6 Mar 2020 19:59:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="DGRjPS4f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D79FD20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3CD86828; Fri, 6 Mar 2020 20:58:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3CD86828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583524766; bh=+LWpMomgvyaFGbCKpYqZkgOFT7jXs4B9vWXusWE/IfI=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DGRjPS4fEPab/YQ0GFDlxT61XOsvpb8mcb+KqQ32t7gTG8H0aZdw5SykCuy/d2CK5 ivKNm2sXeEUNRq3CGlu2DGzjZY7p+0+Kh2lvTsRrzBu7QJ5X1zwo5gbGVKjIBOCCmT w+G1J3SNd6mFMNMZ/xOp1W86+RhrMoYczIyjys7M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AEDF1F801EC; Fri, 6 Mar 2020 20:58:35 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 43255F801ED; Fri, 6 Mar 2020 20:58:31 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 642F6F80125 for ; Fri, 6 Mar 2020 20:58:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 642F6F80125 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2020 11:58:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,523,1574150400"; d="scan'208";a="275662798" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.252.27.83]) ([10.252.27.83]) by fmsmga002.fm.intel.com with ESMTP; 06 Mar 2020 11:58:21 -0800 Subject: Re: [PATCH 5/7] ASoC: Intel: skl_hda_dsp: Enable Dmic configuration To: Pierre-Louis Bossart , Kai Vehmanen References: <20200305145314.32579-1-cezary.rojewski@intel.com> <20200305145314.32579-6-cezary.rojewski@intel.com> <47d77a70-2012-26f5-fda5-7a15e26bcdb4@intel.com> From: Cezary Rojewski Message-ID: <9eeb455f-2976-f7fe-707d-43da57a2ae44@intel.com> Date: Fri, 6 Mar 2020 20:58:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.com, vkoul@kernel.org, broonie@kernel.org, Mateusz Gorski X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2020-03-06 20:49, Pierre-Louis Bossart wrote: >> Guys, we've simply taken long-standing working example such as >> skl_rt286 or bxt_rt298 and applied the missing diff between >> skl_hda_dsp's and said machine boards DAPM routes. skl-pcm.c exposes >> BE: DMIC01 Rx which Intel's SST topologies link against via >> dmic01_hifi. That has always been the case. No bad intentions, the >> exact opposite is true: taken old path approach to make sure nothing >> is broken. Turns out SOF does things differently. Thanks for spotting/ >> testing this out on your end. > > It's actually not SOF, but recent changes in the asoc core that will > stop the probe if a route cannot be added, instead of just spewing a > warning. > > I think it's a good change to force topologies to be complete, but in > cases where a previously released topology cannot be adjusted we need a > backwards compatible solution. that's my plan for the rest of the > afternoon. Agree, missing topology routes should not be permissive. Although my point was about the fact that those 2 routes actually exist in every SST machine driver (in essence linking DMIC01 Rx with platform via internal dmic01_hifi widget). >> Not a problem to adjust topology on our end, though. In fact, I've >> already done that on your requested, tested it out and it works just >> fine. In consequence: >> - this patch will be dropped from the series >> - topology patch provided for alsa-ucm-conf will be updated >> accordingly (dmic01_hifi widget will cease to exist) > > Sounds good, thanks Cezary. Awaiting comments for the rest of the patches if any! Especially how low - kernel version wise - should the fixes be backported. Thanks in advance for your input and time. Czarek