Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Tzung-Bi Shih <tzungbi@google.com>
To: Rong Chen <rong.a.chen@intel.com>
Cc: Gwendal Grignou <gwendal@google.com>,
	devicetree@vger.kernel.org,
	ALSA development <alsa-devel@alsa-project.org>,
	kbuild test robot <lkp@intel.com>,
	Guenter Roeck <groeck@google.com>,
	Nicolas Boichat <drinkcat@google.com>,
	robh+dt@kernel.org, Mark Brown <broonie@kernel.org>,
	kbuild-all@01.org,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Benson Leung <bleung@google.com>, Dylan Reid <dgreid@google.com>,
	Jimmy Cheng-Yi Chiang <cychiang@google.com>
Subject: Re: [alsa-devel] [kbuild-all] Re: [PATCH v2 07/10] ASoC: cros_ec_codec: support WoV
Date: Mon, 14 Oct 2019 18:26:30 +0800
Message-ID: <CA+Px+wUJvpHHM8NuEgjnnU+ObFXFPtNqPheGq5nAOfq4ohRMsQ@mail.gmail.com> (raw)
In-Reply-To: <e02d6319-77b2-b74d-883e-7ec87c5bd1fc@intel.com>

On Wed, Oct 9, 2019 at 3:25 PM Rong Chen <rong.a.chen@intel.com> wrote:
>
>
>
> On 10/7/19 3:04 PM, Tzung-Bi Shih wrote:
> > On Sun, Oct 6, 2019 at 12:54 AM kbuild test robot <lkp@intel.com> wrote:
> >> url:    https://github.com/0day-ci/linux/commits/Tzung-Bi-Shih/ASoC-mediatek-mt8183-mt6358-ts3a227-max98357-support-WoV/20191005-171021
> >> base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> >> reproduce:
> >>          # apt-get install sparse
> >>          # sparse version: v0.6.1-rc1-42-g38eda53-dirty
> >>          make ARCH=x86_64 allmodconfig
> >>          make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> >>
> >> If you fix the issue, kindly add following tag
> >> Reported-by: kbuild test robot <lkp@intel.com>
> >>
> >>
> >> sparse warnings: (new ones prefixed by >>)
> >>
> >>>> sound/soc/codecs/cros_ec_codec.c:430:39: sparse: sparse: incorrect type in return expression (different address spaces) @@    expected void * @@    got void [noderef] <asvoid * @@
> >>>> sound/soc/codecs/cros_ec_codec.c:430:39: sparse:    expected void *
> >>>> sound/soc/codecs/cros_ec_codec.c:430:39: sparse:    got void [noderef] <asn:2> *
> >>>> sound/soc/codecs/cros_ec_codec.c:549:69: sparse: sparse: incorrect type in argument 2 (different address spaces) @@    expected void const volatile [noderef] <asn:2> * @@    got latile [noderef] <asn:2> * @@
> >>>> sound/soc/codecs/cros_ec_codec.c:549:69: sparse:    expected void const volatile [noderef] <asn:2> *
> >>>> sound/soc/codecs/cros_ec_codec.c:549:69: sparse:    got unsigned char [usertype] *addr
> >>>> sound/soc/codecs/cros_ec_codec.c:698:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@    expected void volatile [noderef] <asn:2> * @@    got latile [noderef] <asn:2> * @@
> >>>> sound/soc/codecs/cros_ec_codec.c:698:33: sparse:    expected void volatile [noderef] <asn:2> *
> >>>> sound/soc/codecs/cros_ec_codec.c:698:33: sparse:    got unsigned char [usertype] *wov_lang_shm_p
> >>     sound/soc/codecs/cros_ec_codec.c:699:48: sparse: sparse: incorrect type in argument 1 (different address spaces) @@    expected void volatile [noderef] <asn:2> * @@    got latile [noderef] <asn:2> * @@
> >>     sound/soc/codecs/cros_ec_codec.c:699:48: sparse:    expected void volatile [noderef] <asn:2> *
> >>>> sound/soc/codecs/cros_ec_codec.c:699:48: sparse:    got unsigned char [usertype] *
> > I cannot reproduce the same sparse errors.
> >
> > My commit stack: apply my patches onto broonie/sound.git for-next
> > $ git log --oneline
> > b4471777f5d8 (HEAD -> draft) ASoC: mediatek: mt8183: support WoV
> > b6bb558fa59d ASoC: dt-bindings: mt8183: add ec-codec
> > a08bede115d4 ASoC: mediatek: mt6358: support WoV
> > f67068fd0c91 ASoC: cros_ec_codec: support WoV
> > 7e11271c070e ASoC: dt-bindings: cros_ec_codec: add SHM bindings
> > fd04f20e77d3 ASoC: cros_ec_codec: read max DMIC gain from EC codec
> > c008f01d5bc3 platform/chrome: cros_ec: add common commands for EC codec
> > 50d2c1f9b1f4 ASoC: cros_ec_codec: extract DMIC EC command from I2S RX
> > 00e5a1c121eb ASoC: cros_ec_codec: refactor I2S RX
> > 3f0c475d6ec8 platform/chrome: cros_ec: remove unused EC feature
> > 3877dcd0194c (mark/for-next, asoc-next) Merge branch 'asoc-5.5' into asoc-next
> >
> > My reproduce steps:
> > $ make ARCH=x86_64 mrproper
> > $ make ARCH=x86_64 allmodconfig
> > $ make ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' -j40

Find a typo from my previous message.  It should be "make ARCH=... C=1 ...".

> > 2>&1 | grep -v sched | tee log.txt
> > (Note: filter sched out to not get flood sparse errors)
> > $ grep cros_ec_codec log.txt
> >    CHECK   sound/soc/codecs/cros_ec_codec.c
> >    CC [M]  sound/soc/codecs/cros_ec_codec.o
> >
> > It did not generate the same message as 0day reported.
> >
> > One difference would be the sparse version (it is from "apt install"
> > in my environment):
> > $ sparse --version
> > 0.6.0 (Debian: 0.6.0-3)
> > On the other hand, 0day used "v0.6.1-rc1-42-g38eda53-dirty".
>
> Hi,
>
> The sparse warnings could be generated by the latest sparse
> (https://github.com/lucvoo/sparse.git). Could you try again?

Thanks.  By using the version from github, it can generate the same
sparse errors.
$ sparse --version
v0.6.1-rc1-43-g0ccb3b4

It seems current debian's version (i.e. 0.6.0 (Debian: 0.6.0-3))
cannot reproduce the errors even without the typo mentioned above.

>
> Best Regards,
> Rong Chen
>
> >
> > Guenter, what we could do in the case?  Do you have any idea?
> > _______________________________________________
> > kbuild-all mailing list -- kbuild-all@lists.01.org
> > To unsubscribe send an email to kbuild-all-leave@lists.01.org
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-05  8:54 [alsa-devel] [PATCH v2 00/10] ASoC: mediatek: mt8183-mt6358-ts3a227-max98357: " Tzung-Bi Shih
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 01/10] platform/chrome: cros_ec: remove unused EC feature Tzung-Bi Shih
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 02/10] ASoC: cros_ec_codec: refactor I2S RX Tzung-Bi Shih
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 03/10] ASoC: cros_ec_codec: extract DMIC EC command from " Tzung-Bi Shih
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 04/10] platform/chrome: cros_ec: add common commands for EC codec Tzung-Bi Shih
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 05/10] ASoC: cros_ec_codec: read max DMIC gain from " Tzung-Bi Shih
2019-10-11 15:14   ` Rob Herring
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 06/10] ASoC: dt-bindings: cros_ec_codec: add SHM bindings Tzung-Bi Shih
2019-10-11 15:13   ` Rob Herring
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 07/10] ASoC: cros_ec_codec: support WoV Tzung-Bi Shih
2019-10-05 16:53   ` kbuild test robot
2019-10-07  7:04     ` Tzung-Bi Shih
2019-10-09  7:25       ` [alsa-devel] [kbuild-all] " Rong Chen
2019-10-14 10:26         ` Tzung-Bi Shih [this message]
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 08/10] ASoC: mediatek: mt6358: " Tzung-Bi Shih
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 09/10] ASoC: dt-bindings: mt8183: add ec-codec Tzung-Bi Shih
2019-10-11 15:20   ` Rob Herring
2019-10-12 15:15     ` Tzung-Bi Shih
2019-10-05  8:55 ` [alsa-devel] [PATCH v2 10/10] ASoC: mediatek: mt8183: support WoV Tzung-Bi Shih

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+Px+wUJvpHHM8NuEgjnnU+ObFXFPtNqPheGq5nAOfq4ohRMsQ@mail.gmail.com \
    --to=tzungbi@google.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bleung@google.com \
    --cc=broonie@kernel.org \
    --cc=cychiang@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dgreid@google.com \
    --cc=drinkcat@google.com \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@google.com \
    --cc=gwendal@google.com \
    --cc=kbuild-all@01.org \
    --cc=lkp@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=rong.a.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git