From: Tzung-Bi Shih <tzungbi@google.com>
To: Mark Brown <broonie@kernel.org>
Cc: ALSA development <alsa-devel@alsa-project.org>,
howie.huang@mediatek.com, Takashi Iwai <tiwai@suse.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
shane.chien@mediatek.com, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, eason.yen@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
bicycle.tsai@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document
Date: Wed, 19 Aug 2020 23:42:27 +0800 [thread overview]
Message-ID: <CA+Px+wUV89KO8JJd3+HpOrgFRSc7sdg-DBW44C31262Qx9NzVg@mail.gmail.com> (raw)
In-Reply-To: <20200819103730.GB5441@sirena.org.uk>
On Wed, Aug 19, 2020 at 6:38 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Aug 17, 2020 at 04:11:03PM +0800, Tzung-Bi Shih wrote:
> > I misunderstood. It still needs the compatible string to match the
> > corresponding driver.
>
> No, it doesn't. The MFD should be registering the platform device.
I guess I see. It lists the mfd_cell when calling
devm_mfd_add_devices() in drivers/mfd/mt6397-core.c. It falls back to
use driver name and device name to match. As long as the name
provided in mfd_cell matches the platform driver name, it works.
But I found struct mfd_cell also contains member .of_compatible. What
is the difference if we use compatible string (as is) for this device
instead of falling back to use device name to match?
next prev parent reply other threads:[~2020-08-19 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 6:07 [PATCH v5 0/2] Add mediatek codec mt6359 driver Jiaxin Yu
2020-08-17 6:07 ` [PATCH v5 1/2] ASoC: mediatek: mt6359: add codec driver Jiaxin Yu
2020-08-17 7:32 ` Tzung-Bi Shih
2020-08-17 6:07 ` [PATCH v5 2/2] dt-bindings: mediatek: mt6359: add codec document Jiaxin Yu
2020-08-17 7:29 ` Tzung-Bi Shih
2020-08-17 8:11 ` Tzung-Bi Shih
2020-08-19 10:37 ` Mark Brown
2020-08-19 15:42 ` Tzung-Bi Shih [this message]
2020-08-19 19:40 ` Mark Brown
2020-09-07 13:37 ` Tzung-Bi Shih
2020-09-07 17:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+Px+wUV89KO8JJd3+HpOrgFRSc7sdg-DBW44C31262Qx9NzVg@mail.gmail.com \
--to=tzungbi@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=bicycle.tsai@mediatek.com \
--cc=broonie@kernel.org \
--cc=eason.yen@mediatek.com \
--cc=howie.huang@mediatek.com \
--cc=jiaxin.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shane.chien@mediatek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).