From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Matt Flax <flatmax@flatmax.org>
Subject: Re: ASoc: soc_core.c stream direction from snd_soc_dai
Date: Fri, 26 Feb 2021 13:58:12 +0800 [thread overview]
Message-ID: <CAA+D8AN--agWZpcmsCrAD2OtMAEZxsr+41S1m8UNxynjdV0f+w@mail.gmail.com> (raw)
In-Reply-To: <20210223135743.GG5116@sirena.org.uk>
On Tue, Feb 23, 2021 at 9:58 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Sat, Feb 20, 2021 at 05:29:03PM +0800, Shengjiu Wang wrote:
>
> > One of the suggestions is to use two DAIs. but sometimes the
> > CPU/CODEC may have the same format for playback and capture,
> > then one DAI is enough. it means that we need to define 3 DAIs
> > for the CPU/CODEC, one supports playback and capture, another
> > two support capture and playback separately, is it some kind of
> > duplicate?
>
> > So I'd like to extend the set_fmt() interface, but this impacts all
> > the drivers.
>
> I'm not sure having two DAIs is an issue if you have them running the
> smae format - does it cause any practical problems or is it just that it
> doesn't seem elegant to you? There were quite a few devices that pretty
> much just had two unidirectional DAIs, in those cases it seems like a
> sensible representation for the hardware. If you can set unrelated
> formats on transmit and receive then it's not clear that it's actually
> the same DAI in anything except logical labelling.
When an i2s device, Sometimes it is connected as async mode, there is
different clock for tx and rx then there should be two DAIs, Sometimes
it is connected as sync mode, then there should be one DAI.
So we need to register different DAIs according to the async or sync mode
when the driver probes. right?
best regards
wang shengjiu
next prev parent reply other threads:[~2021-02-26 5:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 22:54 ASoc: soc_core.c stream direction from snd_soc_dai Matt Flax
2020-03-12 22:55 ` Pierre-Louis Bossart
2020-03-12 23:19 ` Matt Flax
2020-03-13 3:56 ` Matt Flax
2020-03-13 9:59 ` Lars-Peter Clausen
2021-02-20 9:29 ` Shengjiu Wang
2021-02-23 13:57 ` Mark Brown
2021-02-26 5:58 ` Shengjiu Wang [this message]
2021-02-26 17:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA+D8AN--agWZpcmsCrAD2OtMAEZxsr+41S1m8UNxynjdV0f+w@mail.gmail.com \
--to=shengjiu.wang@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=flatmax@flatmax.org \
--cc=lars@metafoo.de \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).