From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528ADC433DB for ; Wed, 10 Feb 2021 06:36:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7CCE64E53 for ; Wed, 10 Feb 2021 06:36:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7CCE64E53 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 70B9016B4; Wed, 10 Feb 2021 07:35:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 70B9016B4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612938999; bh=OXavdBpvyb1Dd4oqB+h0ECTg4yI3fOv5ICocqflKLWs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rF/fYxctsn/dlAV63UZi69jrJCApF1FxzINIVJnmf7nmK9Akk65wEtkUBf9GAe+p5 OqtN4NsapBtix9R55i9Q/sRjS/xEdiqrTNMQ4M/r2E9O1E8A5tO84Cq4yLm/RwnppI xp/y/Z1MLi/5UXW6l/BJlBj+dP75x17n4mp2Kkbg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D64BDF8010D; Wed, 10 Feb 2021 07:35:48 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9E340F80165; Wed, 10 Feb 2021 07:35:46 +0100 (CET) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 92ACEF80165 for ; Wed, 10 Feb 2021 07:35:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 92ACEF80165 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U3TeKQmh" Received: by mail-qt1-x834.google.com with SMTP id z22so821359qto.7 for ; Tue, 09 Feb 2021 22:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OXavdBpvyb1Dd4oqB+h0ECTg4yI3fOv5ICocqflKLWs=; b=U3TeKQmh4y3CaWmZxGHT2aKYLXNMmaTMhX74o7qey2Zqpli88QlRz1Xs6iuoUXdHpp vrDeFbsUwEWi9FKGrl/Vq8lyG/053P0M7F+3caw1kPcsncgM7m+SOqRxTLW369Uj/FFq A9qAxPNoHSKxxAxQ4h6PCTAT6kKIn8aoSohjxh7M15EiZ2Qlcez9KGqofJ+nPPNs1QUx 9wUhYhnS7JNDZoy+WNsipI0nlpIZKUnH+4QuClQMepS8wOkv61BhtZ57FjpYx+xCISVn TLP+LLYgiCtBirVf4LfoqCjegiT3D+R7lUdUz6OYnOoczhRPL11mVNSvXNcSxevXYVoh +NYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OXavdBpvyb1Dd4oqB+h0ECTg4yI3fOv5ICocqflKLWs=; b=rkCOMkNn7BijMbhUiudEbdznn/VPvqFsZeA9wVVmuYcDS9vPtlx+kTuFdlxaznRgTX LfGDUqJEGEV/S25majH/uVjHNCmpQKx0rP9A6p974REnTUXHeC62c6/h8tXA8JHHNmUY wZz7kKYpgvt6U+/P7ydWhjg/3Htgw+QGvXI9HAfh8Mvq68fcFhBEIgiY8A6cR4b6SvFg quo1We2m+nDuCAimC6nd2J9bEc+Ha3t2HMwotFLN54QcYSaIJaiwDppKFJ5XkvHqRtTf EmGLzsrSI+cg1QXGkV4XYTqGNdu+NJ/7J8Yw6Yp06nFGjX+NW56LW7yEMlPL/gwoeZSZ ZV+A== X-Gm-Message-State: AOAM532O32BLYx6802NITyL7TRzQxxCxILPmPm5TDQD7iZWgYThjf36A nJxjRIXbPQqFEs9filrUJRw0HW7jGm79HEtPrtM= X-Google-Smtp-Source: ABdhPJxAa/ZPqVfua2S148lPQM0vsrXWY7jYa5ufize6XE/GEpwPCHJc4pF60zzqGbSqwjyqF2HO1qXRtmfQ24UTEcw= X-Received: by 2002:ac8:6f06:: with SMTP id g6mr1460808qtv.360.1612938940598; Tue, 09 Feb 2021 22:35:40 -0800 (PST) MIME-Version: 1.0 References: <1612693435-31418-1-git-send-email-shengjiu.wang@nxp.com> <1612693435-31418-3-git-send-email-shengjiu.wang@nxp.com> <20210208115112.GD8645@sirena.org.uk> <20210209222953.GF4916@sirena.org.uk> In-Reply-To: <20210209222953.GF4916@sirena.org.uk> From: Shengjiu Wang Date: Wed, 10 Feb 2021 14:35:29 +0800 Message-ID: Subject: Re: [PATCH v2 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg To: Mark Brown Content-Type: text/plain; charset="UTF-8" Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , Shengjiu Wang , Takashi Iwai , Liam Girdwood , linux-kernel , Nicolin Chen , Rob Herring , linuxppc-dev@lists.ozlabs.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Feb 10, 2021 at 6:30 AM Mark Brown wrote: > > On Tue, Feb 09, 2021 at 05:16:16PM +0800, Shengjiu Wang wrote: > > On Mon, Feb 8, 2021 at 7:53 PM Mark Brown wrote: > > > > hw_params() can be called multiple times and there's no need for it to > > > be balanced with hw_free(), I'd move this to a different callback (DAPM > > > should work well). > > > Which callback should I use? Is there an example? > > Like I say I'd actually recommend moving this control to DAPM. I may understand your point, you suggest to use the .set_bias_level interface. But in my case I need to enable the clock in earlier stage and keep the clock on when system go to suspend. I am not sure .set_bias_level can met my requirement. we start the Chinese new year holiday now, so currently I can't do test for this recommendation. Maybe we can keep current implementation, can we? Later after I do the test, I can submit another patch for it. Best regards Wang Shengjiu